chore(blockifier_test_utils): delete dead code by dorimedini-starkware · Pull Request #5592 · starkware-libs/sequencer

dorimedini-starkware · 2025-04-05T12:18:15Z

No description provided.

reviewable-StarkWare · 2025-04-05T12:18:25Z

This change is

dorimedini-starkware · 2025-04-05T12:18:27Z

feat(blockifier_test_utils): update CI for cairo recompilation #5594
chore(blockifier_test_utils): delete dead code #5592 👈 (View in Graphite)
feat(blockifier_test_utils): download compilers (async), then recompile all (async) #5591
chore(blockifier_test_utils): delete tag-and-toolchain related code #5589 : 1 other dependent PR (#5590 )
feat(blockifier_test_utils): migrate to new cairo recompilation logic #5588
chore(blockifier_test_utils): extract logic into starknet_sierra_compile #5587 : 1 other dependent PR (#5593 )
chore(blockifier_test_utils): implement verify_cairo1_package #5586
chore(blockifier_test_utils): implement download_cairo_package #5585
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-04-05T14:01:35Z

Artifacts upload workflows:

github-actions · 2025-04-27T16:40:19Z

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.105 ms 34.132 ms 34.163 ms]
change: [-4.6342% -2.9344% -1.4074%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

TzahiTaub

Reviewed 1 of 4 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul and @noaov1)

crates/blockifier_test_utils/src/contracts.rs line 413 at r3 (raw file):

    pub fn all_cairo1_compiler_versions() -> HashSet<CairoVersionString> {
        Self::all_feature_contracts()
            .filter(|contract| contract.cairo_version() != CairoVersion::Cairo0)

Correct me if I'm wrong, this is equivalent to the previous?
Becasue I got confused when I tried to understand what's happening with the Native contracts, but AFAIU they aren't returned in the all_feature_contracts() call at all. I prefer explicit here if they are the same.

Suggestion:

.filter(|contract| contract.cairo_version() == CairoVersion::Cairo1(RunnableCairo1::Casm))

dorimedini-starkware

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul, @noaov1, and @TzahiTaub)

crates/blockifier_test_utils/src/contracts.rs line 413 at r3 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Correct me if I'm wrong, this is equivalent to the previous?
Becasue I got confused when I tried to understand what's happening with the Native contracts, but AFAIU they aren't returned in the all_feature_contracts() call at all. I prefer explicit here if they are the same.

Done.

TzahiTaub

Reviewed 2 of 2 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @elintul and @noaov1)

dorimedini-starkware

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul and @noaov1)

dorimedini-starkware

Reviewed 2 of 2 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul and @noaov1)

github-actions · 2025-05-04T14:13:39Z

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.046 ms 35.552 ms 36.146 ms]
change: [+1.8816% +3.2149% +5.2452%] (p = 0.00 < 0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
7 (7.00%) high severe

TzahiTaub

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul and @noaov1)

This was referenced Apr 5, 2025

chore(blockifier_test_utils): delete tag-and-toolchain related code #5589

Merged

feat(blockifier_test_utils): make compiler download async #5590

Closed

dorimedini-starkware mentioned this pull request Apr 5, 2025

feat(blockifier_test_utils): download compilers (async), then recompile all (async) #5591

Merged

dorimedini-starkware requested review from elintul and noaov1 April 5, 2025 12:19

dorimedini-starkware self-assigned this Apr 5, 2025

dorimedini-starkware marked this pull request as ready for review April 5, 2025 12:20

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from 36086a9 to fd4287c Compare April 5, 2025 12:28

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from 4e07e36 to 5469b3f Compare April 5, 2025 12:28

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from fd4287c to 0f49e79 Compare April 5, 2025 12:35

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from 5469b3f to 1abe47c Compare April 5, 2025 12:35

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from 0f49e79 to 1a039dc Compare April 5, 2025 12:44

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch 2 times, most recently from f7f989b to b8c3c6f Compare April 5, 2025 14:01

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from 1a039dc to 0d3a6b2 Compare April 5, 2025 19:45

dorimedini-starkware mentioned this pull request Apr 5, 2025

chore(blockifier_test_utils): split check from verify of cairo1 package #5593

Closed

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from b8c3c6f to 475cc9a Compare April 5, 2025 19:45

dorimedini-starkware mentioned this pull request Apr 5, 2025

feat(blockifier_test_utils): update CI for cairo recompilation #5594

Merged

dorimedini-starkware requested a review from giladchase April 7, 2025 06:53

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from 0d3a6b2 to a4c748e Compare April 7, 2025 07:40

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from 475cc9a to 20a8cdd Compare April 7, 2025 07:40

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from a4c748e to 713eb0f Compare April 7, 2025 07:58

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from e7d99f3 to bc0e7a1 Compare April 27, 2025 16:27

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from 1e5ef75 to cf18b14 Compare April 28, 2025 09:20

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from bc0e7a1 to 46cfe36 Compare April 28, 2025 09:21

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from cf18b14 to 7db5892 Compare April 29, 2025 08:13

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from 46cfe36 to 717e783 Compare April 29, 2025 08:13

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from 7db5892 to 072e5b8 Compare April 29, 2025 08:55

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from 717e783 to 2058c09 Compare April 29, 2025 08:55

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from 072e5b8 to 5ca6083 Compare April 29, 2025 09:27

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from 2058c09 to 440597c Compare April 29, 2025 09:27

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from 5ca6083 to a73fb50 Compare April 29, 2025 11:33

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from 440597c to b3f7167 Compare April 29, 2025 11:33

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from a73fb50 to 2aa42db Compare May 1, 2025 09:47

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from b3f7167 to e3fadf4 Compare May 1, 2025 09:47

dorimedini-starkware force-pushed the 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ branch from 2aa42db to d95686c Compare May 4, 2025 13:02

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from e3fadf4 to 9be72b5 Compare May 4, 2025 13:02

TzahiTaub suggested changes May 4, 2025

View reviewed changes

chore(blockifier_test_utils): delete dead code

91a5828

dorimedini-starkware force-pushed the 04-05-chore_blockifier_test_utils_delete_dead_code branch from 9be72b5 to 91a5828 Compare May 4, 2025 14:03

dorimedini-starkware changed the base branch from 04-05-feat_blockifier_test_utils_download_compilers_async_then_recompile_all_async_ to main May 4, 2025 14:03

dorimedini-starkware commented May 4, 2025

View reviewed changes

TzahiTaub approved these changes May 4, 2025

View reviewed changes

dorimedini-starkware commented May 4, 2025

View reviewed changes

TzahiTaub approved these changes May 4, 2025

View reviewed changes

dorimedini-starkware added this pull request to the merge queue May 4, 2025

Merged via the queue into main with commit b4ad49e May 4, 2025
16 checks passed

github-actions Bot locked and limited conversation to collaborators May 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(blockifier_test_utils): delete dead code#5592

chore(blockifier_test_utils): delete dead code#5592
dorimedini-starkware merged 1 commit into
mainfrom
04-05-chore_blockifier_test_utils_delete_dead_code

dorimedini-starkware commented Apr 5, 2025

Uh oh!

reviewable-StarkWare commented Apr 5, 2025

Uh oh!

dorimedini-starkware commented Apr 5, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 5, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 27, 2025

Uh oh!

TzahiTaub left a comment

Uh oh!

dorimedini-starkware left a comment

Uh oh!

TzahiTaub left a comment

Uh oh!

dorimedini-starkware left a comment

Uh oh!

dorimedini-starkware left a comment

Uh oh!

github-actions Bot commented May 4, 2025

Uh oh!

TzahiTaub left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dorimedini-starkware commented Apr 5, 2025

Uh oh!

reviewable-StarkWare commented Apr 5, 2025

Uh oh!

dorimedini-starkware commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 27, 2025

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 4, 2025

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dorimedini-starkware commented Apr 5, 2025 •

edited

Loading

github-actions Bot commented Apr 5, 2025 •

edited

Loading