feat(blockifier_test_utils): update CI for cairo recompilation

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• feat(blockifier_test_utils): update CI for cairo recompilation #5594 👈 (View in Graphite)
• chore(blockifier_test_utils): delete dead code #5592
• feat(blockifier_test_utils): download compilers (async), then recompile all (async) #5591
• chore(blockifier_test_utils): delete tag-and-toolchain related code #5589 : 1 other dependent PR (#5590 )
• feat(blockifier_test_utils): migrate to new cairo recompilation logic #5588
• chore(blockifier_test_utils): extract logic into starknet_sierra_compile #5587 : 1 other dependent PR (#5593 )
• chore(blockifier_test_utils): implement verify_cairo1_package #5586
• chore(blockifier_test_utils): implement download_cairo_package #5585
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[giladchase]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @elintul and @noaov1)

---

.github/workflows/blockifier_compiled_cairo.yml line 12 at r2 (raw file):

      - '.github/workflows/blockifier_compiled_cairo.yml'
      - 'crates/apollo_sierra_multicompile/src/constants.rs' # Contains the compiler version.
      - 'crates/blockifier_test_utils/**'

Sure about this one? it could backfire if someone adds new files into the crate, they'll have no way of knowing that they are triggering this check

Code quote:

      - 'crates/blockifier_test_utils/**'

[TzahiTaub]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @elintul, @giladchase, and @noaov1)

---

.github/workflows/blockifier_compiled_cairo.yml line 12 at r2 (raw file):

Previously, dorimedini-starkware wrote…

this check is now fast - and I don't want to miss file renames / code moving to fail to trigger the test now that it isn't painful to rerun. WDYT?

Maybe use this to enforce the current hierarchy? So if someone is moving something the run will fail until it is updated in this file as well. I tend to agree with @giladchase here.

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul, @giladchase, @noaov1, and @TzahiTaub)

---

.github/workflows/blockifier_compiled_cairo.yml line 12 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Maybe use this to enforce the current hierarchy? So if someone is moving something the run will fail until it is updated in this file as well. I tend to agree with @giladchase here.

cool!
we try not to use external actions anymore - need to fork them (after license check) and use internal forks...
I am inclined to simply drop the #[ignore] from the tests and deleting them altogether. the test is now faster than the code_style phase... although, it will add an additional minute to the run_tests phase...
what should we do for now?

[TzahiTaub]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @elintul, @giladchase, and @noaov1)

---

.github/workflows/blockifier_compiled_cairo.yml line 12 at r2 (raw file):

Previously, dorimedini-starkware wrote…

cool!
we try not to use external actions anymore - need to fork them (after license check) and use internal forks...
I am inclined to simply drop the #[ignore] from the tests and deleting them altogether. the test is now faster than the code_style phase... although, it will add an additional minute to the run_tests phase...
what should we do for now?

I don't think so, but it's your call. We can keep your change and just add the hierarchy check as a separate test in every CI run (just hard code a few paths and check they exist).

[TzahiTaub]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @elintul, @giladchase, and @noaov1)

---

.github/workflows/blockifier_compiled_cairo.yml line 12 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

I don't think so, but it's your call. We can keep your change and just add the hierarchy check as a separate test in every CI run (just hard code a few paths and check they exist).

Sorry, meant run this "path" test in your path changes, and keep the recompilation in the previous hirarchy.

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul and @noaov1)

---

.github/workflows/blockifier_compiled_cairo.yml line 12 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Sorry, meant run this "path" test in your path changes, and keep the recompilation in the previous hirarchy.

Sent the action to roei, we'll get a fork and add these existence checks across the board on all workflows (that are triggered by specific files / paths)

[github-actions]

Artifacts upload workflows:

• Started at 2025-05-04T16:43:58Z

[dorimedini-starkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul and @noaov1)