chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils#5871
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e2d3ea4 to
c6425a3
Compare
df44274 to
7d86c6e
Compare
c6425a3 to
f035ca4
Compare
7d86c6e to
024acbb
Compare
f035ca4 to
54752d1
Compare
024acbb to
4ef812e
Compare
54752d1 to
338e7c8
Compare
4ef812e to
a3edd26
Compare
338e7c8 to
e7806c4
Compare
a3edd26 to
eb75670
Compare
604a8a1 to
a8b380d
Compare
31464c4 to
1bfbc5f
Compare
a8b380d to
ce18fa2
Compare
1bfbc5f to
aad1dfa
Compare
ce18fa2 to
cc5c41e
Compare
aad1dfa to
26fc9e2
Compare
cc5c41e to
1379226
Compare
26fc9e2 to
08f666d
Compare
1379226 to
dc2e669
Compare
08f666d to
167c5cc
Compare
dc2e669 to
cfe02f2
Compare
167c5cc to
955d3d5
Compare
cfe02f2 to
af7902f
Compare
955d3d5 to
c0fb063
Compare
af7902f to
8e9762f
Compare
c0fb063 to
a76b94d
Compare
8e9762f to
3918bc8
Compare
a76b94d to
5b2a89d
Compare
3918bc8 to
35c733d
Compare
5b2a89d to
8742f34
Compare
35c733d to
8578843
Compare
8742f34 to
9d0e592
Compare
amosStarkware
left a comment
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware and @TzahiTaub)
crates/apollo_infra_utils/src/lib.rs line 1 at r2 (raw file):
pub mod cairo0_compiler;
is apollo_infra_utils the best place for utils for compiling cairo0 code?
won't non-apollo-related crates also use it?
crates/apollo_infra_utils/src/cairo0_compiler.rs line 1 at r2 (raw file):
use std::fs;
This PR only moves code, right?
TzahiTaub
left a comment
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @nimrod-starkware)
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @nimrod-starkware)
crates/apollo_infra_utils/src/cairo0_compiler.rs line 1 at r2 (raw file):
Previously, amosStarkware wrote…
This PR only moves code, right?
yes
crates/apollo_infra_utils/src/lib.rs line 1 at r2 (raw file):
Previously, amosStarkware wrote…
is
apollo_infra_utilsthe best place for utils for compiling cairo0 code?
won't non-apollo-related crates also use it?
apollo_infra_utils is all shared utils for all crates in the repo; we can consider splitting between repo-wide and sequencer(apollo)-wide utils, but it's out of scope ATM
…ompiler_deps to infra_utils
amosStarkware
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

No description provided.