Skip to content

chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils#5871

Merged
dorimedini-starkware merged 1 commit into
main-v0.14.0from
04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils
May 25, 2025
Merged

chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils#5871
dorimedini-starkware merged 1 commit into
main-v0.14.0from
04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented Apr 15, 2025

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware self-assigned this Apr 15, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review April 15, 2025 14:16
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_copy_os_cairo_code branch from e2d3ea4 to c6425a3 Compare April 15, 2025 14:30
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from df44274 to 7d86c6e Compare April 15, 2025 14:31
@dorimedini-starkware dorimedini-starkware marked this pull request as draft April 15, 2025 14:32
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_copy_os_cairo_code branch from c6425a3 to f035ca4 Compare April 15, 2025 15:08
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 7d86c6e to 024acbb Compare April 15, 2025 15:08
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_copy_os_cairo_code branch from f035ca4 to 54752d1 Compare April 15, 2025 16:15
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 024acbb to 4ef812e Compare April 15, 2025 16:15
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_copy_os_cairo_code branch from 54752d1 to 338e7c8 Compare April 17, 2025 13:52
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 4ef812e to a3edd26 Compare April 17, 2025 13:52
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-feat_apollo_starknet_os_program_copy_os_cairo_code branch from 338e7c8 to e7806c4 Compare April 17, 2025 13:57
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from a3edd26 to eb75670 Compare April 17, 2025 13:57
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 604a8a1 to a8b380d Compare May 2, 2025 14:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-feat_starknet_committer_and_os_cli_add_command_to_dump_os_source_files branch from 31464c4 to 1bfbc5f Compare May 5, 2025 10:59
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from a8b380d to ce18fa2 Compare May 5, 2025 10:59
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-feat_starknet_committer_and_os_cli_add_command_to_dump_os_source_files branch from 1bfbc5f to aad1dfa Compare May 5, 2025 12:50
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from ce18fa2 to cc5c41e Compare May 5, 2025 12:50
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-feat_starknet_committer_and_os_cli_add_command_to_dump_os_source_files branch from aad1dfa to 26fc9e2 Compare May 5, 2025 13:08
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from cc5c41e to 1379226 Compare May 5, 2025 13:09
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-feat_starknet_committer_and_os_cli_add_command_to_dump_os_source_files branch from 26fc9e2 to 08f666d Compare May 6, 2025 12:26
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 1379226 to dc2e669 Compare May 6, 2025 12:26
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-feat_starknet_committer_and_os_cli_add_command_to_dump_os_source_files branch from 08f666d to 167c5cc Compare May 6, 2025 14:25
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from dc2e669 to cfe02f2 Compare May 6, 2025 14:25
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-feat_starknet_committer_and_os_cli_add_command_to_dump_os_source_files branch from 167c5cc to 955d3d5 Compare May 6, 2025 14:51
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from cfe02f2 to af7902f Compare May 6, 2025 14:51
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-feat_starknet_committer_and_os_cli_add_command_to_dump_os_source_files branch from 955d3d5 to c0fb063 Compare May 8, 2025 09:22
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from af7902f to 8e9762f Compare May 8, 2025 09:22
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-feat_starknet_committer_and_os_cli_add_command_to_dump_os_source_files branch from c0fb063 to a76b94d Compare May 8, 2025 09:51
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 8e9762f to 3918bc8 Compare May 8, 2025 09:52
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-feat_starknet_committer_and_os_cli_add_command_to_dump_os_source_files branch from a76b94d to 5b2a89d Compare May 8, 2025 16:12
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 3918bc8 to 35c733d Compare May 8, 2025 16:12
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-feat_starknet_committer_and_os_cli_add_command_to_dump_os_source_files branch from 5b2a89d to 8742f34 Compare May 8, 2025 17:34
@dorimedini-starkware dorimedini-starkware force-pushed the 04-13-chore_apollo_infra_utils_blockifier_test_utils_move_verify_cairo0_compiler_deps_to_infra_utils branch from 35c733d to 8578843 Compare May 8, 2025 17:35
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-feat_starknet_committer_and_os_cli_add_command_to_dump_os_source_files branch from 8742f34 to 9d0e592 Compare May 9, 2025 09:34

@amosStarkware amosStarkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware and @TzahiTaub)


crates/apollo_infra_utils/src/lib.rs line 1 at r2 (raw file):

pub mod cairo0_compiler;

is apollo_infra_utils the best place for utils for compiling cairo0 code?
won't non-apollo-related crates also use it?


crates/apollo_infra_utils/src/cairo0_compiler.rs line 1 at r2 (raw file):

use std::fs;

This PR only moves code, right?

@TzahiTaub TzahiTaub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @nimrod-starkware)

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @nimrod-starkware)


crates/apollo_infra_utils/src/cairo0_compiler.rs line 1 at r2 (raw file):

Previously, amosStarkware wrote…

This PR only moves code, right?

yes


crates/apollo_infra_utils/src/lib.rs line 1 at r2 (raw file):

Previously, amosStarkware wrote…

is apollo_infra_utils the best place for utils for compiling cairo0 code?
won't non-apollo-related crates also use it?

apollo_infra_utils is all shared utils for all crates in the repo; we can consider splitting between repo-wide and sequencer(apollo)-wide utils, but it's out of scope ATM

@amosStarkware amosStarkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants