feat(starknet_os): remove the program from the OS runner inputs by dorimedini-starkware · Pull Request #5877 · starkware-libs/sequencer

dorimedini-starkware · 2025-04-15T14:13:37Z

No description provided.

reviewable-StarkWare · 2025-04-15T14:13:49Z

This change is

dorimedini-starkware · 2025-04-15T14:13:59Z

test(starknet_os): deprecated syscall hint strings test #6992
test(starknet_os): deprecated syscall hint consistency test #6988
test(starknet_os): hint consistency test with local program objects #6931
feat(starknet_os): remove the program from the OS runner inputs #5877 👈 (View in Graphite)
feat(apollo_starknet_os_program): add test contracts, add dumper in CLI #5946 : 1 other dependent PR (#6069 )
feat(apollo_starknet_os_program): compile programs asynchronously #5945
feat(apollo_starknet_os_program): add command to dump aggregator program #5943 : 1 other dependent PR (#5944 )
feat(apollo_starknet_os_program): add aggregator program + program hash(es) #5937
test(ci): prepare apollo_starknet_os_program for publishing #5933
feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876
feat(apollo_starknet_os_program): add fixer for program hash test #5875
feat(apollo_starknet_os_program): define and implement static ProgramHash #5874
feat(apollo_starknet_os_program): define and implement static Program #5873
fix(ci): properly install python deps, in CI and docker #5902 : 1 other dependent PR (#6266 )
feat(apollo_infra_utils): better cairo0 compiler checks #5921
chore(apollo_infra_utils): explicit instructions in verify_cairo0_compiler_deps #5872
chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils #5871
main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-04-15T14:14:56Z

Artifacts upload workflows:

dorimedini-starkware

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @nimrod-starkware and @TzahiTaub)

a discussion (no related file):
py side

github-actions · 2025-04-17T14:09:59Z

Benchmark movements: full_committer_flow performance regressed! full_committer_flow time: [30.359 ms 30.446 ms 30.554 ms] change: [+1.1604% +1.5727% +1.9821%] (p = 0.00 < 0.05) Performance has regressed. Found 4 outliers among 100 measurements (4.00%) 2 (2.00%) high mild 2 (2.00%) high severe

github-actions · 2025-04-19T17:47:22Z

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.098 ms 34.147 ms 34.205 ms]
change: [-4.6049% -3.1049% -1.7883%] (p = 0.00 < 0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
5 (5.00%) high mild
6 (6.00%) high severe

TzahiTaub

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @nimrod-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

py side

Pease update

dorimedini-starkware

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @TzahiTaub)

a discussion (no related file):

Previously, TzahiTaub (Tzahi) wrote…

Pease update

new py side

TzahiTaub

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @nimrod-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

new py side

Waiting for it to pass

dorimedini-starkware

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @TzahiTaub)

a discussion (no related file):

Previously, TzahiTaub (Tzahi) wrote…

Waiting for it to pass

will require some changes (TODO cleanup logic is causing string mismatches, I think). will push a fix to this pr first; PTAL at the two preceding PRs for now (5945, 5946)

TzahiTaub

Reviewed 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

TzahiTaub

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

TzahiTaub

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

dorimedini-starkware

Reviewed 4 of 5 files at r3, 1 of 1 files at r5, 1 of 1 files at r7, 7 of 7 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

dorimedini-starkware requested review from TzahiTaub and nimrod-starkware April 15, 2025 14:15

dorimedini-starkware self-assigned this Apr 15, 2025

dorimedini-starkware marked this pull request as ready for review April 15, 2025 14:16

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 83d6363 to 1dbb071 Compare April 15, 2025 14:31

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from e325490 to 728954b Compare April 15, 2025 14:31

dorimedini-starkware marked this pull request as draft April 15, 2025 14:33

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 1dbb071 to d9d9e5f Compare April 15, 2025 14:56

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from 728954b to 8fe7b87 Compare April 15, 2025 14:56

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from d9d9e5f to 8688f92 Compare April 15, 2025 15:09

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from 8fe7b87 to a1fd18f Compare April 15, 2025 15:09

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 8688f92 to 4061106 Compare April 15, 2025 15:49

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from a1fd18f to 866c853 Compare April 15, 2025 15:49

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 4061106 to 97825d7 Compare April 15, 2025 16:15

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from 866c853 to af6a8b7 Compare April 15, 2025 16:15

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 97825d7 to 2e6df53 Compare April 15, 2025 16:32

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from af6a8b7 to 2d9c368 Compare April 15, 2025 16:33

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 2e6df53 to da89616 Compare April 16, 2025 07:31

dorimedini-starkware mentioned this pull request Apr 17, 2025

feat(apollo_infra_utils): better cairo0 compiler checks #5921

Merged

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from bd3f4a9 to 1e184ad Compare April 17, 2025 10:04

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from 3055a4d to 306eb83 Compare April 17, 2025 10:04

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 1e184ad to 9562232 Compare April 17, 2025 10:13

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from 306eb83 to 9246a65 Compare April 17, 2025 10:13

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 9562232 to d93c4f8 Compare April 17, 2025 10:26

dorimedini-starkware commented Apr 17, 2025

View reviewed changes

dorimedini-starkware mentioned this pull request Apr 17, 2025

test(ci): prepare apollo_starknet_os_program for publishing #5933

Merged

dorimedini-starkware mentioned this pull request Apr 22, 2025

feat(apollo_starknet_os_program): add OS constants template file #6069

Closed

TzahiTaub reviewed Jun 3, 2025

View reviewed changes

dorimedini-starkware commented Jun 3, 2025

View reviewed changes

TzahiTaub suggested changes Jun 3, 2025

View reviewed changes

dorimedini-starkware commented Jun 3, 2025

View reviewed changes

dorimedini-starkware mentioned this pull request Jun 3, 2025

test(starknet_os): hint consistency test with local program objects #6931

Merged

TzahiTaub approved these changes Jun 4, 2025

View reviewed changes

dorimedini-starkware added 3 commits June 4, 2025 17:10

feat(apollo_starknet_os_program): compile programs asynchronously

db02f56

feat(apollo_starknet_os_program): add test contracts, add dumper in CLI

03b37e8

feat(starknet_os): remove the program from the OS runner inputs

394fb8f

TzahiTaub approved these changes Jun 5, 2025

View reviewed changes

This was referenced Jun 5, 2025

test(starknet_os): deprecated syscall hint consistency test #6988

Merged

test(starknet_os): deprecated syscall hint strings test #6992

Merged

dorimedini-starkware commented Jun 5, 2025

View reviewed changes

Conversation

dorimedini-starkware commented Apr 15, 2025

Uh oh!

reviewable-StarkWare commented Apr 15, 2025

Uh oh!

dorimedini-starkware commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 19, 2025

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dorimedini-starkware commented Apr 15, 2025 •

edited

Loading

github-actions Bot commented Apr 15, 2025 •

edited

Loading

github-actions Bot commented Apr 17, 2025 •

edited

Loading