fix(ci): properly install python deps, in CI and docker#5902
Merged
dorimedini-starkware merged 1 commit intoMay 26, 2025
Merged
Conversation
|
This change is |
This was referenced Apr 16, 2025
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dorimedini-starkware
requested review from
Itay-Tsabary-Starkware and
idan-starkware
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
2 times, most recently
from
038c7b8 to
5a84f67
Compare
Contributor
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Conceptual 
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @idan-starkware)
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
2 times, most recently
from
37732fb to
c6a76e2
Compare
Collaborator
Author
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
there are 5 PRs below this one, and design review is a week from now, so it will take time :)
thanks though
Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @idan-starkware)
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
c6a76e2 to
aa62c10
Compare
dorimedini-starkware
changed the base branch from
04-13-chore_apollo_infra_utils_explicit_instructions_in_verify_cairo0_compiler_deps
to
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
|
Artifacts upload workflows: |
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
f38a4b3 to
b461536
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
aa62c10 to
fcc7e77
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
b461536 to
c163a0d
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
fcc7e77 to
419e274
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
4015497 to
72854ad
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
a26141c to
1191dd6
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
72854ad to
d1d5487
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
1191dd6 to
3edb313
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
d1d5487 to
a81aec8
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
3edb313 to
4458146
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
a81aec8 to
3165ee8
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
4458146 to
3c1b15e
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
3165ee8 to
761dfbf
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
3c1b15e to
ca28c80
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
761dfbf to
6bd0ed0
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
ca28c80 to
2bbfd9b
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
6bd0ed0 to
f74618c
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
2bbfd9b to
968cc47
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
f74618c to
57b6dfc
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
968cc47 to
96a33be
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
57b6dfc to
85ce43a
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
96a33be to
e08d551
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
85ce43a to
6e5b341
Compare
dorimedini-starkware
force-pushed
the
04-16-fix_ci_properly_install_python_deps_in_ci_and_docker
branch
from
e08d551 to
d722761
Compare
dorimedini-starkware
force-pushed
the
04-17-feat_apollo_infra_utils_better_cairo0_compiler_checks
branch
from
6e5b341 to
0b00ce2
Compare
idan-starkware
approved these changes
May 26, 2025
Contributor
amosStarkware
left a comment
amosStarkware
left a comment
There was a problem hiding this comment.
Reviewed 1 of 6 files at r1, 5 of 8 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: 7 of 9 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
Collaborator
Author
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 2 of 8 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
|
Benchmark movements: No major performance changes detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.