test(ci): prepare apollo_starknet_os_program for publishing by dorimedini-starkware · Pull Request #5933 · starkware-libs/sequencer

dorimedini-starkware · 2025-04-17T13:29:18Z

No description provided.

reviewable-StarkWare · 2025-04-17T13:29:26Z

This change is

dorimedini-starkware · 2025-04-17T13:29:52Z

feat(apollo_starknet_os_program): add command to dump aggregator program #5943 : 2 dependent PRs (#5944 , #5945 )
feat(apollo_starknet_os_program): add aggregator program + program hash(es) #5937
test(ci): prepare apollo_starknet_os_program for publishing #5933 👈 (View in Graphite)
feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876
feat(apollo_starknet_os_program): add fixer for program hash test #5875
feat(apollo_starknet_os_program): define and implement static ProgramHash #5874
feat(apollo_starknet_os_program): define and implement static Program #5873
fix(ci): properly install python deps, in CI and docker #5902 : 1 other dependent PR (#6266 )
feat(apollo_infra_utils): better cairo0 compiler checks #5921
chore(apollo_infra_utils): explicit instructions in verify_cairo0_compiler_deps #5872
chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils #5871
main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-04-17T13:30:41Z

Artifacts upload workflows:

github-actions · 2025-05-26T13:27:36Z

Benchmark movements: No major performance changes detected.

TzahiTaub

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @nimrod-starkware)

workspace_tests/version_integrity_test.rs line 14 at r2 (raw file):

const PARENT_BRANCH: &str = include_str!("../scripts/parent_branch.txt");
const MAIN_PARENT_BRANCH: &str = "main";

Unrelated

Suggestion:

MAIN_BRANCH

dorimedini-starkware

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)

workspace_tests/version_integrity_test.rs line 14 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Unrelated

I think it's good that it matches the name of the parent_branch.txt file; how about PARENT_BRANCH? without the MAIN_?

TzahiTaub

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @dorimedini-starkware, and @nimrod-starkware)

workspace_tests/version_integrity_test.rs line 14 at r2 (raw file):

Previously, dorimedini-starkware wrote…

I think it's good that it matches the name of the parent_branch.txt file; how about PARENT_BRANCH? without the MAIN_?

I think you've looked at the wrong const 🙂 . I suggest keeping the PARENT_BRANCH above, and changing the MAIN_PARENT_BRANCH that is a line below, and was probably copied from the first.

dorimedini-starkware

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)

workspace_tests/version_integrity_test.rs line 14 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

I think you've looked at the wrong const 🙂 . I suggest keeping the PARENT_BRANCH above, and changing the MAIN_PARENT_BRANCH that is a line below, and was probably copied from the first.

ahhh right you are
done

TzahiTaub

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

dorimedini-starkware

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware and @nimrod-starkware)

dorimedini-starkware mentioned this pull request Apr 17, 2025

feat(apollo_infra_utils): better cairo0 compiler checks #5921

Merged

dorimedini-starkware requested review from TzahiTaub and nimrod-starkware April 17, 2025 13:30

dorimedini-starkware self-assigned this Apr 17, 2025

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from d3aec12 to 80a3c36 Compare April 17, 2025 13:53

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 0ce9251 to fb39974 Compare April 17, 2025 13:53

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from 80a3c36 to e825e2c Compare April 17, 2025 13:58

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from fb39974 to 4285720 Compare April 17, 2025 13:58

dorimedini-starkware mentioned this pull request Apr 17, 2025

feat(apollo_starknet_os_program): add aggregator program + program hash(es) #5937

Merged

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from e825e2c to 54559d9 Compare April 17, 2025 18:36

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 4285720 to bca7a50 Compare April 17, 2025 18:36

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from 54559d9 to fef0fee Compare April 17, 2025 18:54

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from bca7a50 to d36ae68 Compare April 17, 2025 18:54

dorimedini-starkware mentioned this pull request Apr 18, 2025

feat(apollo_starknet_os_program): add command to dump aggregator program #5943

Merged

dorimedini-starkware force-pushed the 04-14-feat_starknet_os_remove_the_program_from_the_os_runner_inputs branch from fef0fee to d2bb6a1 Compare April 18, 2025 10:05

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from d36ae68 to 1cd12cf Compare April 18, 2025 10:05

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 289c560 to 1b61458 Compare April 30, 2025 17:50

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from e33ac04 to 992092c Compare April 30, 2025 18:54

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 1b61458 to ec43aed Compare April 30, 2025 18:54

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 992092c to 8d21c22 Compare April 30, 2025 21:12

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from ec43aed to 7c821de Compare April 30, 2025 21:13

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 8d21c22 to cbb30a2 Compare May 1, 2025 09:42

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 7c821de to f78ef01 Compare May 1, 2025 09:42

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from cbb30a2 to b19279c Compare May 1, 2025 09:45

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from f78ef01 to 7802669 Compare May 1, 2025 09:45

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from b19279c to 1b5c0a9 Compare May 5, 2025 11:32

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 7802669 to f2055cb Compare May 5, 2025 11:32

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 1b5c0a9 to 352577a Compare May 5, 2025 12:54

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from f2055cb to 2a4c18d Compare May 5, 2025 12:54

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 352577a to ffb1f7f Compare May 6, 2025 12:27

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 2a4c18d to 7dbed53 Compare May 6, 2025 12:27

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from ffb1f7f to 50bcaaa Compare May 6, 2025 12:37

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from 7dbed53 to ae5ecfb Compare May 6, 2025 12:37

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 50bcaaa to 0a438d2 Compare May 6, 2025 12:53

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from ae5ecfb to dee7200 Compare May 6, 2025 12:54

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 0a438d2 to 02c9306 Compare May 6, 2025 13:30

dorimedini-starkware force-pushed the 04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing branch from dee7200 to 80cdf40 Compare May 6, 2025 13:30

dorimedini-starkware force-pushed the 04-14-feat_starknet_committer_and_os_cli_add_command_to_dump_the_os_compiled_program_to_file branch from 02c9306 to 9161fb5 Compare May 6, 2025 14:10

TzahiTaub approved these changes May 27, 2025

View reviewed changes

dorimedini-starkware commented May 27, 2025

View reviewed changes

TzahiTaub approved these changes May 27, 2025

View reviewed changes

dorimedini-starkware commented May 27, 2025

View reviewed changes

TzahiTaub approved these changes May 28, 2025

View reviewed changes

test(ci): prepare apollo_starknet_os_program for publishing

663b3bd

dorimedini-starkware commented May 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(ci): prepare apollo_starknet_os_program for publishing#5933

test(ci): prepare apollo_starknet_os_program for publishing#5933
dorimedini-starkware merged 1 commit into
main-v0.14.0from
04-17-test_ci_prepare_apollo_starknet_os_program_for_publishing

dorimedini-starkware commented Apr 17, 2025

Uh oh!

reviewable-StarkWare commented Apr 17, 2025

Uh oh!

dorimedini-starkware commented Apr 17, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 17, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented May 26, 2025 •

edited

Loading

Uh oh!

TzahiTaub left a comment

Uh oh!

dorimedini-starkware left a comment

Uh oh!

TzahiTaub left a comment

Uh oh!

dorimedini-starkware left a comment

Uh oh!

TzahiTaub left a comment

Uh oh!

dorimedini-starkware left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dorimedini-starkware commented Apr 17, 2025

Uh oh!

reviewable-StarkWare commented Apr 17, 2025

Uh oh!

dorimedini-starkware commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

TzahiTaub left a comment

Choose a reason for hiding this comment

Uh oh!

dorimedini-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dorimedini-starkware commented Apr 17, 2025 •

edited

Loading

github-actions Bot commented Apr 17, 2025 •

edited

Loading

github-actions Bot commented May 26, 2025 •

edited

Loading