Update Start.io User ID module to ensure callbacks and AJAX requests fire regardless of endpoint validity

Author: IlliaMil

modules/startioSystem.js

@@ -5,6 +5,7 @@ import { getStorageManager, STORAGE_TYPE_COOKIES, STORAGE_TYPE_LOCALSTORAGE } fr
 import { MODULE_TYPE_UID } from '../src/activities/modules.js';
 
 const MODULE_NAME = 'startioId';
+const DEFAULT_ENDPOINT = '';
 export const storage = getStorageManager({ moduleType: MODULE_TYPE_UID, moduleName: MODULE_NAME });
 
 function storeId(id, storageConfig = {}) {
@@ -33,16 +34,12 @@ export const startioIdSubmodule = {
   getId(config, consentData, storedId) {
     const configParams = (config && config.params) || {};
     const storageConfig = (config && config.storage) || {};
+    const endpoint = configParams.endpoint || DEFAULT_ENDPOINT;
 
     if (storedId) {
       return { id: storedId };
     }
 
-    if (!configParams.endpoint || typeof configParams.endpoint !== 'string') {
-      logError(`${MODULE_NAME} module requires an endpoint parameter.`);
-      return;
-    }
-
     const resp = function (callback) {
       const callbacks = {
         success: response => {
@@ -65,7 +62,7 @@ export const startioIdSubmodule = {
           callback();
         }
       };
-      ajax(configParams.endpoint, callbacks, undefined, { method: 'GET' });
+      ajax(endpoint, callbacks, undefined, { method: 'GET' });
     };
     return { callback: resp };
   },

test/spec/modules/startioSystem_spec.js

@@ -64,17 +64,26 @@ describe('StartIO ID System', function () {
   });
 
   describe('getId', function () {
-    it('should log an error if no endpoint configured', function () {
+    it('should return callback and fire ajax even if no endpoint configured', function () {
       const config = { params: {} };
-      startioIdSubmodule.getId(config);
-      expect(utils.logError.calledOnce).to.be.true;
-      expect(utils.logError.args[0][0]).to.include('requires an endpoint');
+      const result = startioIdSubmodule.getId(config);
+      expect(result).to.have.property('callback');
+      expect(typeof result.callback).to.equal('function');
+
+      const callbackSpy = sinon.spy();
+      result.callback(callbackSpy);
+      expect(server.requests.length).to.equal(1);
     });
 
-    it('should log an error if endpoint is not a string', function () {
+    it('should return callback and fire ajax even if endpoint is not a string', function () {
       const config = { params: { endpoint: 123 } };
-      startioIdSubmodule.getId(config);
-      expect(utils.logError.calledOnce).to.be.true;
+      const result = startioIdSubmodule.getId(config);
+      expect(result).to.have.property('callback');
+      expect(typeof result.callback).to.equal('function');
+
+      const callbackSpy = sinon.spy();
+      result.callback(callbackSpy);
+      expect(server.requests.length).to.equal(1);
     });
 
     it('should return existing storedId immediately if provided', function () {