add the repository field in order to avoid the new npm v1.2.20 warning#2
Open
trjh wants to merge 2 commits into
Open
add the repository field in order to avoid the new npm v1.2.20 warning#2trjh wants to merge 2 commits into
trjh wants to merge 2 commits into
Conversation
npm WARN package.json bitstarter-ssjs-orders@0.0.1 No repository field. (bit trivial, but had me briefly confused)
- skip heroku login and .env copy steps, as my build takes care of that - skip ssh key bits, as i use ssh -A from my laptop index.html changes: - add my own button code (instead of class one) - use my own google analytics tags (though i seem to have forgot one of them) web.js change: - add some code used during exploration of this module, and javascript. shows me how objects/variables work, demonstrated my suspicion that .env wasn't automagically passed to heroku (i missed the config:push bit in the instructions), played a bit with JSON parsing, and a simple dev-vs-production trigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"npm WARN package.json bitstarter-ssjs-orders@0.0.1 No repository field."
(bit trivial, but had me briefly confused)