spi_tranfer: factorize common code to simplify maintenance#1
Merged
stas2z merged 1 commit intostas2z:masterfrom Feb 7, 2020
Merged
spi_tranfer: factorize common code to simplify maintenance#1stas2z merged 1 commit intostas2z:masterfrom
stas2z merged 1 commit intostas2z:masterfrom
Conversation
Owner
|
Actually, im sure it does impact perfomance cuz it have to check skipReceive at every byte sent instead of checking it just before transfer loop start ive checked it with my lcds, it takes about 5% of transfer perfomance (simple buffer-to-screen test case) no matter of optimisations enabled (ive checked -Os/-O2/-O3 as most common) sure it's not so much and probably we can waste it for better readability |
Author
|
I am surprised, because:
Whatever, as you said 5% is worth for better readability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi @stas2z
I review the PR
stm32duino#912
That is nice job and looks good to me.
Nevertheless I propose to factorize common code to improve readability and maintenance.
I does not impact performances. (tested on NUCLEO_L476RG with LCD/SD sadafruit shield).