[9.x] Fix updated_at timestamp not updating when field is read-only#807
Merged
Conversation
|
Released as part of v9.4.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the
updated_attimestamp wasn't being updated when it was configured as aread_onlyfield in the blueprint.This was happening because
read_onlyfields are still saved, so the value was run through the fieldtype'sprocess()method and set on the model viasetAttribute. This made theupdated_atattribute dirty in the model's attributes array, which prevented Laravel'supdateTimestamps()from auto-updating the timestamp (it skips columns that are already dirty), causing the stale value to be saved.This PR fixes it by skipping
setAttributefor timestamp columns (updated_at/created_at) when the field isread_onlyand the model uses timestamps, allowing Laravel's automatic timestamp handling to work as expected.Fixes #805