[9.x] Support nested fields in title_field and title_format#808
Draft
duncanmcclean wants to merge 1 commit into
Draft
[9.x] Support nested fields in title_field and title_format#808duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where setting
title_fieldto a nested field (e.g.,values_alt_title) didn't work correctly. Listings would either show blank titles or relationship fields would fail to display titles, depending on whether the arrow (meta->name) or underscore (meta_name) syntax was used.This was happening because all call sites that read the title value used direct attribute access (
$model->getAttribute(...)or$model->{$titleField}), which can't resolve values from nested JSON columns. Nested fields need to be read usingdata_get($model, "prefix.key").This PR fixes it by adding three helper methods to
Resource:titleValue(Model $model)— reads the title value from a model, usingdata_get()for nested fieldstitleDbColumn()— returns the database column path (e.g.,values->alt_title) for use in query orderingsetTitleValue(Model $model, $value)— writes a title value back to the model, handling nested JSON columnsAll call sites that previously accessed the title value directly now use these methods instead.
Fixes #703