Skip to content

Commit 2750f0d

Browse files
authored
[6.x] Fieldset editing improvements (#14283)
* Actually show the Fieldset title (not just the handle) * Add link to edit actual Fieldset * Flip it around so the label is to edit the Fieldset and a Cog button configures the import. Later we can replace the href with a Stack * Disambiguate tooltips * Show prefix in a badge
1 parent a9d4d74 commit 2750f0d

1 file changed

Lines changed: 20 additions & 4 deletions

File tree

resources/js/components/blueprints/ImportField.vue

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,20 @@
88
<div class="flex flex-1 items-center py-2">
99
<ui-icon class="size-4 me-2 text-ui-accent-text/80" name="fieldsets" />
1010
<div class="flex items-center gap-2">
11-
<!-- @TODO: Show fieldset.title -->
12-
<button class="cursor-pointer overflow-hidden text-ellipsis text-sm text-ui-accent-text hover:text-ui-accent-text/80" v-text="field.fieldset" @click="$emit('edit')" />
11+
<a class="cursor-pointer overflow-hidden text-ellipsis text-sm text-ui-accent-text hover:text-ui-accent-text/80" :href="fieldsetEditUrl" v-text="fieldsetTitle" v-tooltip="__('Edit fieldset')" />
1312
<ui-icon name="link" class="text-gray-400" />
1413
<span class="text-gray-500 font-mono text-2xs" v-text="__('Fieldset')" />
14+
<ui-badge
15+
v-if="field.prefix"
16+
size="sm"
17+
color="gray"
18+
:text="`${__('Prefix')}: ${field.prefix}`"
19+
/>
1520
</div>
1621
</div>
17-
<div class="flex items-center gap-2">
18-
<ui-button size="sm" icon="trash" variant="subtle" @click.prevent="$emit('deleted')" v-tooltip="__('Remove')" />
22+
<div class="flex items-center">
23+
<ui-button size="sm" icon="cog" variant="subtle" inset @click.prevent="$emit('edit')" v-tooltip="__('Configure import')" />
24+
<ui-button size="sm" icon="trash" variant="subtle" inset @click.prevent="$emit('deleted')" v-tooltip="__('Remove')" />
1925
<ui-stack :open="isEditing" @update:open="editorClosed" inset :show-close-button="false" :wrap-slot="false">
2026
<field-settings
2127
ref="settings"
@@ -50,6 +56,16 @@ export default {
5056
},
5157
5258
computed: {
59+
fieldsetTitle() {
60+
const title = this.$page?.props?.fieldsets?.[this.field.fieldset]?.title;
61+
62+
return title ? __(title) : this.field.fieldset;
63+
},
64+
65+
fieldsetEditUrl() {
66+
return cp_url(`fields/fieldsets/${this.field.fieldset}/edit`);
67+
},
68+
5369
fieldConfig() {
5470
const { _id, type, ...config } = this.field;
5571
return config;

0 commit comments

Comments
 (0)