[5.x] Ensure asset validation rules are returned as strings to GraphQL (#11781)

Author: ryanmitchell

src/Fieldtypes/Assets/DimensionsRule.php

@@ -124,4 +124,9 @@ protected function failsRatioCheck($parameters, $width, $height)
 
         return abs($numerator / $denominator - $width / $height) > $precision;
     }
+
+    public function __toString()
+    {
+        return 'dimensions:'.implode(',', $this->parameters);
+    }
 }

src/Fieldtypes/Assets/ImageRule.php

@@ -49,4 +49,9 @@ public function message()
     {
         return __((Statamic::isCpRoute() ? 'statamic::' : '').'validation.image');
     }
+
+    public function __toString()
+    {
+        return 'image:'.implode(',', $this->parameters);
+    }
 }

src/Fieldtypes/Assets/MimesRule.php

@@ -51,4 +51,9 @@ public function message()
     {
         return str_replace(':values', implode(', ', $this->parameters), __((Statamic::isCpRoute() ? 'statamic::' : '').'validation.mimes'));
     }
+
+    public function __toString()
+    {
+        return 'mimes:'.implode(',', $this->parameters);
+    }
 }

src/Fieldtypes/Assets/MimetypesRule.php

@@ -46,4 +46,9 @@ public function message()
     {
         return str_replace(':values', implode(', ', $this->parameters), __((Statamic::isCpRoute() ? 'statamic::' : '').'validation.mimetypes'));
     }
+
+    public function __toString()
+    {
+        return 'mimetypes:'.implode(',', $this->parameters);
+    }
 }

src/Fieldtypes/Assets/SizeBasedRule.php

@@ -66,4 +66,9 @@ protected function getFileSize($id)
 
         return false;
     }
+
+    public function __toString()
+    {
+        return 'size:'.implode(',', $this->parameters);
+    }
 }

src/GraphQL/Types/FormType.php

@@ -35,7 +35,21 @@ public function fields(): array
             'rules' => [
                 'type' => GraphQL::type(ArrayType::NAME),
                 'resolve' => function ($form, $args, $context, $info) {
-                    return $form->blueprint()->fields()->validator()->rules();
+                    return collect($form->blueprint()->fields()->validator()->rules())
+                        ->map(function ($rules) {
+                            return collect($rules)->map(function ($rule) {
+                                if (is_string($rule)) {
+                                    return $rule;
+                                }
+
+                                if ($rule instanceof \Stringable) {
+                                    return (string) $rule;
+                                }
+
+                                return $rule;
+                            });
+                        })
+                        ->all();
                 },
             ],
             'sections' => [

tests/Feature/GraphQL/FormTest.php

@@ -317,4 +317,53 @@ public function it_queries_the_sections()
                 ],
             ]]);
     }
+
+    #[Test]
+    public function it_returns_string_based_validation_rules_for_mimes_mimetypes_dimension_size_and_image()
+    {
+        Form::make('contact')->title('Contact Us')->save();
+
+        $blueprint = Blueprint::makeFromFields([
+            'name' => [
+                'type' => 'assets',
+                'display' => 'Asset',
+                'validate' => [
+                    'mimes:image/jpeg,image/png',
+                    'mimetypes:image/jpeg,image/png',
+                    'dimensions:1024',
+                    'size:1000',
+                    'image:jpeg',
+                ],
+            ],
+        ]);
+
+        BlueprintRepository::shouldReceive('find')->with('forms.contact')->andReturn($blueprint);
+
+        $query = <<<'GQL'
+{
+    form(handle: "contact") {
+        rules
+    }
+}
+GQL;
+        $this
+            ->withoutExceptionHandling()
+            ->post('/graphql', ['query' => $query])
+            ->assertGqlOk()
+            ->assertExactJson(['data' => [
+                'form' => [
+                    'rules' => [
+                        'name' => [
+                            'mimes:image/jpeg,image/png',
+                            'mimetypes:image/jpeg,image/png',
+                            'dimensions:1024',
+                            'size:1000',
+                            'image:jpeg',
+                            'array',
+                            'nullable',
+                        ],
+                    ],
+                ],
+            ]]);
+    }
 }