Skip to content

Commit 840d093

Browse files
stoffelioclaudejasonvarga
authored
[6.x] Default the create user wizard super toggle to false (#14927)
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Jason Varga <jason@pixelfear.com>
1 parent 453d79a commit 840d093

2 files changed

Lines changed: 31 additions & 1 deletion

File tree

resources/js/components/users/Wizard.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ export default {
235235
data() {
236236
return {
237237
user: {
238-
super: this.canCreateSupers,
238+
super: false,
239239
roles: [],
240240
groups: [],
241241
},

tests/Feature/Users/StoreUserTest.php

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ public function it_creates_a_user()
3535
->actingAsWithElevatedSession($me)
3636
->store()
3737
->assertOk();
38+
39+
$this->assertFalse(User::findByEmail('test@domain.com')->isSuper());
3840
}
3941

4042
#[Test]
@@ -48,4 +50,32 @@ public function it_requires_an_elevated_session()
4850
->store()
4951
->assertElevatedSessionRequiredJsonResponse();
5052
}
53+
54+
#[Test]
55+
public function super_users_can_create_a_super_user()
56+
{
57+
$this->setTestRoles(['test' => ['access cp', 'create users']]);
58+
$me = tap(User::make()->email('admin@domain.com')->assignRole('test')->makeSuper())->save();
59+
60+
$this
61+
->actingAsWithElevatedSession($me)
62+
->store(['super' => true])
63+
->assertOk();
64+
65+
$this->assertTrue(User::findByEmail('test@domain.com')->isSuper());
66+
}
67+
68+
#[Test]
69+
public function non_super_users_cannot_create_a_super_user()
70+
{
71+
$this->setTestRoles(['test' => ['access cp', 'create users']]);
72+
$me = tap(User::make()->email('admin@domain.com')->assignRole('test'))->save();
73+
74+
$this
75+
->actingAsWithElevatedSession($me)
76+
->store(['super' => true])
77+
->assertOk();
78+
79+
$this->assertFalse(User::findByEmail('test@domain.com')->isSuper());
80+
}
5181
}

0 commit comments

Comments
 (0)