[5.x] Fix storing submissions of forms with 'files' fieldtypes even when disabled (#11794)

Author: andjsch

src/Forms/DeleteTemporaryAttachments.php

@@ -31,6 +31,8 @@ public function handle()
                 $this->submission->remove($field->handle());
             });
 
-        $this->submission->saveQuietly();
+        if ($this->submission->form()->store()) {
+            $this->submission->saveQuietly();
+        }
     }
 }

tests/Forms/SendEmailsTest.php

@@ -5,6 +5,7 @@
 use Illuminate\Support\Facades\Bus;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Test;
+use Statamic\Contracts\Forms\SubmissionRepository;
 use Statamic\Facades\Form as FacadesForm;
 use Statamic\Facades\Site;
 use Statamic\Forms\DeleteTemporaryAttachments;
@@ -115,6 +116,29 @@ public function it_dispatches_delete_attachments_job_after_dispatching_email_job
         ]);
     }
 
+    #[Test]
+    public function delete_attachments_job_only_saves_submission_when_enabled()
+    {
+        $form = tap(FacadesForm::make('attachments_test')->email([
+            'from' => 'first@sender.com',
+            'to' => 'first@recipient.com',
+            'foo' => 'bar',
+        ]))->save();
+
+        $form
+            ->store(false)
+            ->blueprint()
+            ->ensureField('attachments', ['type' => 'files'])->save();
+
+        $submission = $form->makeSubmission();
+
+        (new DeleteTemporaryAttachments($submission))->handle();
+
+        $submissions = app(SubmissionRepository::class)->all();
+
+        $this->assertEmpty($submissions);
+    }
+
     #[Test]
     #[DataProvider('noEmailsProvider')]
     public function no_email_jobs_are_queued_if_none_are_configured($emailConfig)