[6.x] Remove deprecated function calls (#14457)

Co-authored-by: Jason Varga <jason@pixelfear.com>

Author: justindantzer

src/View/Antlers/Language/Runtime/RuntimeParser.php

@@ -510,7 +510,6 @@ private function addAntlersErrorDetails($exception, $text, $data)
         $rebuiltTrace = array_merge($rebuiltTrace, $exception->getTrace());
 
         $traceProperty = new ReflectionProperty('Exception', 'trace');
-        $traceProperty->setAccessible(true);
         $traceProperty->setValue($newException, $rebuiltTrace);
 
         $this->cleanUpTempFiles();
@@ -606,7 +605,6 @@ private function buildAntlersExceptionError(AntlersException $antlersException,
 
         $ignitionException = new $exceptionClass($newMessage, 0, 1, $exceptionView, $exceptionLine, $antlersException);
         $traceProperty = new ReflectionProperty('Exception', 'trace');
-        $traceProperty->setAccessible(true);
         $traceProperty->setValue($ignitionException, $rebuiltTrace);
 
         $ignitionException->setViewData($data);

src/Yaml/Yaml.php

@@ -136,7 +136,6 @@ protected function viewException($e, $str, $line = null)
             'args' => $args,
         ]);
         $traceProperty = new ReflectionProperty('Exception', 'trace');
-        $traceProperty->setAccessible(true);
         $traceProperty->setValue($exception, $trace);
 
         return $exception;

tests/Assets/AssetTest.php

@@ -953,7 +953,6 @@ public function when_saving_quietly_the_cached_assets_withEvents_flag_will_be_se
 
         $reflection = new ReflectionClass($asset);
         $property = $reflection->getProperty('withEvents');
-        $property->setAccessible(true);
         $withEvents = $property->getValue($asset);
         $this->assertTrue($withEvents);
     }

tests/Auth/ElevatedSessionTest.php

@@ -437,7 +437,6 @@ public function it_returns_passkey_method_when_config_is_false_and_user_has_pass
         // Use reflection to set the passkeys property
         $reflection = new \ReflectionClass($user);
         $property = $reflection->getProperty('passkeys');
-        $property->setAccessible(true);
         $property->setValue($user, $mockCollection);
 
         $this->assertEquals('passkey', $user->getElevatedSessionMethod());
@@ -456,7 +455,6 @@ public function it_returns_password_confirmation_method_when_config_is_true_even
         // Use reflection to set the passkeys property
         $reflection = new \ReflectionClass($user);
         $property = $reflection->getProperty('passkeys');
-        $property->setAccessible(true);
         $property->setValue($user, $mockCollection);
 
         $this->assertEquals('password_confirmation', $user->getElevatedSessionMethod());
@@ -493,7 +491,6 @@ public function it_can_get_passkey_options_for_elevated_session()
         // Use reflection to set the passkeys property
         $reflection = new \ReflectionClass($user);
         $property = $reflection->getProperty('passkeys');
-        $property->setAccessible(true);
         $property->setValue($user, $mockCollection);
 
         $response = $this
@@ -520,7 +517,6 @@ public function it_can_start_elevated_session_with_passkey()
         // Use reflection to set the passkeys property
         $reflection = new \ReflectionClass($user);
         $property = $reflection->getProperty('passkeys');
-        $property->setAccessible(true);
         $property->setValue($user, $mockCollection);
 
         $credentials = [
@@ -556,7 +552,6 @@ public function status_endpoint_returns_passkey_method()
         // Use reflection to set the passkeys property
         $reflection = new \ReflectionClass($user);
         $property = $reflection->getProperty('passkeys');
-        $property->setAccessible(true);
         $property->setValue($user, $mockCollection);
 
         $this

tests/Data/Entries/EntryTest.php

@@ -1430,7 +1430,6 @@ public function when_saving_quietly_the_cached_entrys_withEvents_flag_will_be_se
         $cached = Cache::get('stache::items::entries::blog::1');
         $reflection = new ReflectionClass($cached);
         $property = $reflection->getProperty('withEvents');
-        $property->setAccessible(true);
         $withEvents = $property->getValue($cached);
         $this->assertTrue($withEvents);
     }

tests/Feature/GraphQL/Fieldtypes/DateFieldtypeTest.php

@@ -19,7 +19,6 @@ public function setUp(): void
             $reflection = new ReflectionClass(self::this());
 
             $factory = $reflection->getMethod('getFactory');
-            $factory->setAccessible(true);
 
             return Arr::get($factory->invoke(self::this())->getSettings(), 'toStringFormat');
         });

tests/Fieldtypes/UsersTest.php

@@ -164,7 +164,6 @@ private function cpUserWithPermissions(array $permissions)
     private function getColumns(Users $fieldtype): array
     {
         $method = new \ReflectionMethod($fieldtype, 'getColumns');
-        $method->setAccessible(true);
 
         return $method->invoke($fieldtype);
     }

tests/Imaging/GlideTest.php

@@ -174,12 +174,10 @@ private function defaultFolderVisibility($filesystem)
 
         $reflection = new \ReflectionClass($adapter);
         $visibilityConverter = $reflection->getProperty('visibility');
-        $visibilityConverter->setAccessible(true);
         $visibilityConverter = $visibilityConverter->getValue($adapter);
 
         $reflection = new \ReflectionClass($visibilityConverter);
         $visibility = $reflection->getProperty('defaultForDirectories');
-        $visibility->setAccessible(true);
 
         return $visibility->getValue($visibilityConverter);
     }
@@ -188,7 +186,6 @@ private function getAdapterFromFilesystem($filesystem)
     {
         $reflection = new \ReflectionClass($filesystem);
         $property = $reflection->getProperty('adapter');
-        $property->setAccessible(true);
 
         return $property->getValue($filesystem);
     }
@@ -197,7 +194,6 @@ private function getRootFromLocalAdapter($adapter)
     {
         $reflection = new \ReflectionClass($adapter);
         $property = $reflection->getProperty('prefixer');
-        $property->setAccessible(true);
         $prefixer = $property->getValue($adapter);
 
         return $prefixer->prefixPath('');

tests/Imaging/ImageGeneratorTest.php

@@ -445,7 +445,6 @@ private function getRootFromLocalAdapter($adapter)
     {
         $reflection = new \ReflectionClass($adapter);
         $property = $reflection->getProperty('prefixer');
-        $property->setAccessible(true);
         $prefixer = $property->getValue($adapter);
 
         return $prefixer->prefixPath('');
@@ -455,7 +454,6 @@ private function getAdapterFromFilesystem($filesystem)
     {
         $reflection = new \ReflectionClass($filesystem);
         $property = $reflection->getProperty('adapter');
-        $property->setAccessible(true);
 
         return $property->getValue($filesystem);
     }

tests/Stache/StoreTest.php

@@ -38,7 +38,6 @@ public function it_forces_a_trailing_slash_when_setting_the_directory()
         // Check the value of the property to make sure the property was set with
         // the slash, and that ->directory() isn't just appending it.
         $property = (new \ReflectionClass($this->store))->getProperty('directory');
-        $property->setAccessible(true);
         $this->assertEquals('/path/to/directory/', $property->getValue($this->store));
     }