[5.x] Reindex numerical array keys in filter_empty modifier

[daun]

Currently, the filter_empty modifier only filters the results without reindexing keys, which results in skipped indexes on numerical arrays. This becomes a problem when casting to json. Since the array has missing indexes, it gets stringified into an object instead of an array, breaking js functionality.

This fix consists in making sure that numerical arrays going into the modifier also come out as numerical arrays. Associative arrays and collections are left as is.

Example

<div x-data='{ categories: {{ categories | filter_empty | to_json }} }'>

Before

<div x-data='{ categories: { "1": "shirts", "3": "pants" }'>

After

<div x-data='{ categories: ["shirts", "pants"] }'>

[jasonvarga]

Thanks for this but the intention is to keep it similar to $collection->filter() or array_filter().

If you want it reindexed you can chain the values modifier on it.

{{ categories | filter_empty | values | to_json }}