[5.x] Use deep copy of set's data in bard field#11766
Merged
jasonvarga merged 1 commit intostatamic:5.xfrom May 7, 2025
Merged
[5.x] Use deep copy of set's data in bard field#11766jasonvarga merged 1 commit intostatamic:5.xfrom
jasonvarga merged 1 commit intostatamic:5.xfrom
Conversation
duncanmcclean
changed the title
faltjo
force-pushed
the
fix-bard-set-replicator-bug
branch
from
e1a6a01 to
ffd1f32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #11765
Instead of a shallow copy, a deep copy of the (default) values is used when adding or duplicating set defined for a bard field.
When using statamic from this branch, the problems are gone in the example repo: https://github.com/faltjo/fix-bard-field-set-bug
Note that this is very similar to #11621