[6.x] Add <ui-combobox> component (select fieldtype)#11771
Merged
jasonvarga merged 36 commits intouifrom May 15, 2025
Merged
Conversation
duncanmcclean
changed the title
<ui-combobox> component (select fieldtype)
This reverts commit c23bb4b.
Otherwise, Vue will think we want the browser's input event, which will obviously break stuff.
Otherwise, when you're using a typeahead relationship field and the `<Combobox>` is mounted, there won't be any `options` passed in, so the currently selected option isn't visible. By displaying the option label in the relationship fieldtype, we have the option's object (allowing us to get the title).
jackmcdade
approved these changes
May 14, 2025
Member
jackmcdade
left a comment
jackmcdade
left a comment
There was a problem hiding this comment.
Fantastic work @duncanmcclean!
jasonvarga
requested changes
May 14, 2025
Member
jasonvarga
left a comment
jasonvarga
left a comment
There was a problem hiding this comment.
If you could make ui/Select/Select.vue a wrapper around <Combobox> with with the searchable and maxSelections props set to false and 1 respectively by default, that'll be good.
duncanmcclean
commented
May 15, 2025
| </SelectContent> | ||
| </SelectPortal> | ||
| </SelectRoot> | ||
| <Combobox |
Member
Author
There was a problem hiding this comment.
We don't need to add :max-selections="1" here since it'll default to a single select without the multiple prop set.
Member
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
<Combobox>component, built on top of Reka's combobox.This PR also integrates it nearly everywhere we were previously using
<v-select>, like the select fieldtype, icon fieldtype and relationship fieldtypes.CleanShot.2025-05-07.at.16.16.46.mp4