[6.x] Fix some reactivity issues#11775
Merged
jasonvarga merged 3 commits intomasterfrom May 8, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one of the 6.x changes (either upgrading to Vue 3, or switching to Pinia) when you try to add a new set to a Replicator, it wouldn't update the meta data and caused an error. This seemed to be because the preview text was updating within the meta at around the same moment. This is fixed by making the previews and the row's meta get updated in the same call.
Also, the set's previews were displaying incorrectly due to the following change in #11610.
They were showing the handles and incorrect values. Now they just show correct values again.
Finally, there were some reactivity issues around meta data. For example, the initial replicator previews show as null (which is how they come down from the server). The first time the components update them, they aren't reflected. If you collapsed a set that had data in it, you wouldn't see any preview text. You'd need to edit a field for it to update.
Removing the clones seems to fix this. Tracing back where they were first added was like 7 years ago so maybe they were addressing a Vue 2 issue. Vue 3 might just work better. I don't see any issues.