[6.x] Modals#11879
Merged
Merged
Conversation
Otherwise, as soon as the `<Modal>` component is rendered, its displayed. The modal can still be used *without* the parent component managing state.
Member
Author
|
@jasonvarga What are your thoughts on the open/close changes in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates modals across our application to use the new
<Modal>UI component.In the process, I've also converted buttons/inputs/selects/etc in modals to use UI new versions of those components.
Modal Open/Closed State
This PR also makes some changes to how a modal's open state is controlled.
Previously, modals would open after the user clicked the "trigger". This meant that there wasn't any way to open a modal programatically, or prevent it from closing (in the case of an in-progress AJAX request).
While the modal's open state can still be handled by the model itself, it can now also be opened & closed using
v-modelbindings: