Merged
Conversation
…ories Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jasonvarga
changed the title
… packages Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jasonvarga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixtures for the composer tests were requiring
composer/composeras a dependency. Because of this, Dependabot would want to update it when there are security issues. Rather than continually updating the version - I've removed it. Turns out it's not even necessary.However now having no dependencies surfaced a bug where
installedwould be an empty array rather than an object, so you'd get anAttempt to read property "installed" on arrayerror. In practice you'd never have no dependencies but it's fixed anyway.This also fixes the globs used in the GitHub action workflow so it actually runs. Ironically I tried to fix it in #13736 but that only seemed like it worked because the tests.yml was edited. Hopefully this PR doesn't do the exact same thing. 😄