[6.x] Update currencies dictionary with all circulating currencies#14516
Closed
tdrayson wants to merge 1 commit intostatamic:6.xfrom
Closed
[6.x] Update currencies dictionary with all circulating currencies#14516tdrayson wants to merge 1 commit intostatamic:6.xfrom
tdrayson wants to merge 1 commit intostatamic:6.xfrom
Conversation
Member
|
Thank you for the PR. You've just updated the language file, which doesn't make the values appear in the field. Please feel free to update this PR after you've implemented the changes in the dictionary and actually tested it. |
Contributor
Author
|
Hey, sorry @jasonvarga, first time contributing to Statamic. I've opened a new PR #14520, confirmed and tested it works and also updated both the translation file and the dictionary file. |
Member
|
Awesome, thanks. |
Contributor
|
I am sorry to say that the wikipedia list of circulating currencies is in no way a relevant source of information. Wikipedia cannot be listed as a relevant source for anything. ISO4217 is, absolutely. With the appropriate link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using the dictionary in my project, I noticed several currencies were missing for countries I was trying to add. This PR adds 40 missing currency codes, sourced from the Wikipedia list of circulating currencies, to align the dictionary with the current ISO 4217 list:
AOA, AWG, BBD, BMD, BSD, BTN, CUP, FJD, FKP, GIP, GMD, GYD, HTG, KGS, KPW, KYD, LAK, LRD, LSL, MNT, MRU, MVR, MWK, PGK, SBD, SCR, SHP, SLE, SRD, SSP, STN, SZL, TJS, TMT, VED, VUV, WST, XCD, XCG, and XPF.
Also updates
PENlabel from "Peruvian Nuevo Sol" to "Peruvian Sol" to reflect the 2015 currency renaming.