[6.x] Fix blank term edit screen and JS error for restricted users#14537
Merged
jasonvarga merged 1 commit into6.xfrom Apr 23, 2026
Merged
[6.x] Fix blank term edit screen and JS error for restricted users#14537jasonvarga merged 1 commit into6.xfrom
jasonvarga merged 1 commit into6.xfrom
Conversation
jasonvarga
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now when you use the Control Panel as a restricted user (e.g. multi-site with permission to access only one site) and you try to edit a taxonomy term, you see a blank publish form and the console shows the following error:
The reason is that
getAuthorizedSitesForTaxonomy()returns a filtered collection with non-sequential keys. Without->values(), JSON can encode that as an object instead of an array, so the CP JS fails onthis.localizations.find(...).Adding
->values()reindexes the collection so it's an array in JSON.Thanks to Theo for pointing out that bug through support!