[6.x] Fix LivePreview listener leak and simplify Grid row updates#14583
Merged
jasonvarga merged 2 commits into6.xfrom Apr 30, 2026
Merged
[6.x] Fix LivePreview listener leak and simplify Grid row updates#14583jasonvarga merged 2 commits into6.xfrom
jasonvarga merged 2 commits into6.xfrom
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Waldemar Pankratz <waldemar.pankratz@voll.digital>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes/improvements extracted from #14512
LivePreview event-listener leak
resources/js/components/ui/LivePreview/LivePreview.vueregisters alive-preview.<name>.refreshhandler onStatamic.$eventsbut never$offs it on unmount, so navigating between live-preview-enabled entries leaks listeners. Hoisted the handler into a named const and$offit inonUnmountedalongside the existingkeybinding.value.destroy().Grid Row shallow spread
resources/js/components/fieldtypes/grid/Row.vuewas deep-cloning the row/meta object on every field update (viaJSON.parse(JSON.stringify(...))andclone()) just to set a single key. Replaced with a shallow spread, which is enough since downstream consumers don't mutate the emitted object.Since
updatedfires on every keystroke, the deep clone was walking the entire row's nested data (Bard docs, nested Replicator sets, etc.) on each character. The spread is a one-level copy, which on heavy rows is the difference between a noticeable typing lag and none.