Skip to content

[6.x] Debounce LinkFieldtype URL writes #14584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 3 commits into from
Apr 30, 2026
Merged

[6.x] Debounce LinkFieldtype URL writes #14584

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
262928c
Add attribution.
jasonvarga Apr 30, 2026
37637de
Debounce LinkFieldtype URL writes and short-circuit unchanged meta
jasonvarga Apr 30, 2026
69facc2
Merge remote-tracking branch 'origin/6.x' into implement-pr-b
jasonvarga Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions resources/js/components/fieldtypes/LinkFieldtype.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
<script>
import Fieldtype from './Fieldtype.vue';
import { Input, Select } from '@/components/ui';
import debounce from '@/util/debounce.js';
import { markRaw } from 'vue';

export default {
components: { Input, Text, Select },
Expand All @@ -60,6 +62,13 @@ export default {
};
},

created() {
this.syncUrlDebounced = markRaw(debounce((url) => {
this.update(url);
this.updateMeta({ ...this.meta, initialUrl: url });
}, 150));
},

computed: {
entryValue() {
return this.selectedEntries.length ? `entry::${this.selectedEntries[0]}` : null;
Expand Down Expand Up @@ -116,12 +125,11 @@ export default {

urlValue(url) {
if (this.metaChanging) return;

this.update(url);
this.updateMeta({ ...this.meta, initialUrl: url });
this.syncUrlDebounced(url);
},

meta(meta, oldMeta) {
if (meta === oldMeta) return;
if (JSON.stringify(meta) === JSON.stringify(oldMeta)) return;

this.metaChanging = true;
Expand Down
Loading