[🐛 Bug]: syncing state is broken#147
Draft
christian-bromann wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
christian-bromann
marked this pull request as draft
June 22, 2022 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VSCode Environment
all
Marquee Version
all
Workspace Type
Local Workspace
What happened?
Currently every widget with an
ExtensionManagercalls:when it gets initiated. So this happens multiple times for multiple widgets. The problem with that is that it should be called once for all keys that should be synced. Calling it with a different array of keys will replace keys already called by a different widget.
What is your expected behavior?
Collect all keys that are supposed to be synced and call the method then.
Relevant Log Output
n/a
Code of Conduct
Is there an existing issue for this?