Skip to content

V2#67

Draft
davidkpiano wants to merge 34 commits into
nextfrom
v2
Draft

V2#67
davidkpiano wants to merge 34 commits into
nextfrom
v2

Conversation

@davidkpiano
Copy link
Copy Markdown
Member

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 3, 2026

🦋 Changeset detected

Latest commit: c169a3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@statelyai/agent Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown

@JiwaniZakir JiwaniZakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The email2.ts file adds a getStuff function with meaningful state-mapping logic, but main() is left completely empty — it's unclear if this is intentional scaffolding or an accidentally incomplete example. If it's meant to demonstrate usage, wiring getStuff into main would make the intent clearer; if it's truly a stub, a comment or TODO would help. Additionally, pnpm-lock.yaml is being committed into examples_old/hono/, which is unusual for an archived/deprecated directory — if these examples are being superseded by V2, locking in transitive dependencies here adds noise without benefit. The @cloudflare/vite-plugin version constraint in package.json is ^1.2.3, but the lockfile resolves it to 1.22.1, which while technically within the semver range is a significant jump that could mask compatibility assumptions. It would be worth pinning the constraint more tightly if this example is expected to work as-is.

@davidkpiano
Copy link
Copy Markdown
Member Author

The email2.ts file adds a getStuff function with meaningful state-mapping logic, but main() is left completely empty — it's unclear if this is intentional scaffolding or an accidentally incomplete example. If it's meant to demonstrate usage, wiring getStuff into main would make the intent clearer; if it's truly a stub, a comment or TODO would help. Additionally, pnpm-lock.yaml is being committed into examples_old/hono/, which is unusual for an archived/deprecated directory — if these examples are being superseded by V2, locking in transitive dependencies here adds noise without benefit. The @cloudflare/vite-plugin version constraint in package.json is ^1.2.3, but the lockfile resolves it to 1.22.1, which while technically within the semver range is a significant jump that could mask compatibility assumptions. It would be worth pinning the constraint more tightly if this example is expected to work as-is.

Almost certain this is AI-generated @JiwaniZakir. Please prompt whatever AI agent you're using that it's supposed to disregard draft PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants