Merge pull request #80 from staticdev/float-max-size

Add fractional max size

Author: Thiago C. D'Ávila

README.rst

@@ -93,7 +93,7 @@ Usage
 
    pdf-split-tool --max-size 50 # for 50 megabytes
 
-Note: you can also use --max-size after the path of a specific PDF.
+Note: you can also use --max-size after the path of a specific PDF and fractional numbers such as "50.5".
 
 
 Contributing

src/pdf_split_tool/__main__.py

@@ -1,4 +1,6 @@
 """Command-line interface."""
+import math
+
 import click
 
 import pdf_split_tool.file_handler
@@ -34,14 +36,14 @@ def _confirm_split_file(filepath: str, max_size_bytes: int) -> None:
 @click.option(
     "-m",
     "--max-size",
-    type=int,
+    type=float,
     help="Max size in megabytes.",
     default=20,
     show_default=True,
 )
-def main(filepath: str, max_size: int) -> None:
+def main(filepath: str, max_size: float) -> None:
     """Pdf Split Tool."""
-    max_size_bytes = max_size * 1024 * 1024  # convert to MB
+    max_size_bytes = math.floor(max_size * 1024 * 1024)  # convert to bytes
     if filepath.endswith(".pdf"):
         _confirm_split_file(filepath, max_size_bytes)
     else:

tests/test_main.py

@@ -81,3 +81,13 @@ def test_main_uses_specified_filepath(
         with open("test.pdf", "w"):
             result = runner.invoke(__main__.main, ["test.pdf"])
     assert result.exit_code == 0
+
+
+def test_main_uses_float_max_size(
+    runner: click.testing.CliRunner, mock_pdf_splitter_pdfsplitter: Mock,
+) -> None:
+    """It uses the specified filepath."""
+    with runner.isolated_filesystem():
+        with open("test.pdf", "w"):
+            result = runner.invoke(__main__.main, ["-m", "0.5"])
+    assert result.exit_code == 0