Fix 5 bugs: Logger.warn data loss, falsy value handling, logging flag, boolean upsert, DM query

- Logger.warn: Accept Error|Record as 3rd param so Error objects aren't
  silently treated as data, dropping the actual data argument
- NodeStore: Use ?? instead of || for hwModel and snr so valid zero
  values (hwModel=UNSET, snr=0) aren't discarded
- enableLogging: Default to false so --enable-logging flag actually works
  (was always true, making the flag a no-op)
- upsertNode: Pass 0 instead of null for false viaMqtt/isFavorite so
  COALESCE doesn't silently preserve stale true values
- getDMConversations: Use correlated subquery for last_message instead of
  bare column with GROUP BY, which returns indeterminate results in SQLite

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
(cherry picked from commit 805e17f)

Author: statico

src/db/index.ts

@@ -423,9 +423,9 @@ export function upsertNode(node: DbNode) {
     node.channelUtilization ?? null,
     node.airUtilTx ?? null,
     node.channel ?? null,
-    node.viaMqtt ? 1 : null,
+    node.viaMqtt != null ? (node.viaMqtt ? 1 : 0) : null,
     node.hopsAway ?? null,
-    node.isFavorite ? 1 : null,
+    node.isFavorite != null ? (node.isFavorite ? 1 : 0) : null,
     node.publicKey ?? null,
     Date.now(),
   ]);
@@ -879,19 +879,27 @@ export function getDMConversations(myNodeNum: number): DMConversation[] {
   // A DM is either: to_node = myNodeNum (received) or from_node = myNodeNum AND to_node != broadcast (sent)
     const rows = ensureDb().query(`
     SELECT
-      CASE
-        WHEN from_node = ? THEN to_node
-        ELSE from_node
-      END as other_node,
-      text as last_message,
-      MAX(timestamp) as last_timestamp,
-      SUM(CASE WHEN from_node != ? AND status = 'received' THEN 1 ELSE 0 END) as unread_count
-    FROM messages
-    WHERE to_node != ?
-      AND (from_node = ? OR to_node = ?)
+      other_node,
+      (SELECT m2.text FROM messages m2
+       WHERE m2.to_node != ?
+         AND ((m2.from_node = ? AND m2.to_node = other_node) OR (m2.from_node = other_node AND m2.to_node = ?))
+       ORDER BY m2.timestamp DESC LIMIT 1) as last_message,
+      MAX(m.timestamp) as last_timestamp,
+      SUM(CASE WHEN m.from_node != ? AND m.status = 'received' THEN 1 ELSE 0 END) as unread_count
+    FROM (
+      SELECT
+        CASE
+          WHEN from_node = ? THEN to_node
+          ELSE from_node
+        END as other_node,
+        from_node, timestamp, status
+      FROM messages
+      WHERE to_node != ?
+        AND (from_node = ? OR to_node = ?)
+    ) m
     GROUP BY other_node
     ORDER BY last_timestamp DESC
-  `).all(myNodeNum, myNodeNum, BROADCAST_ADDR, myNodeNum, myNodeNum) as Array<{
+  `).all(BROADCAST_ADDR, myNodeNum, myNodeNum, myNodeNum, myNodeNum, BROADCAST_ADDR, myNodeNum, myNodeNum) as Array<{
     other_node: number;
     last_message: string;
     last_timestamp: number;

src/index.ts

@@ -283,7 +283,7 @@ let session = "default";
 let clearSession = false;
 let meshViewUrl: string | undefined;
 let useFahrenheit = false;
-let enableLogging = true;
+let enableLogging = false;
 let packetLimit = 1000;
 let httpPort: number | undefined;
 let useTls = false;

src/logger.ts

@@ -42,8 +42,14 @@ class Logger {
     Logger.instance?.log(LogLevel.INFO, context, message, data);
   }
 
-  static warn(context: string, message: string, data?: Record<string, any>): void {
-    Logger.instance?.log(LogLevel.WARN, context, message, data);
+  static warn(context: string, message: string, errorOrData?: Error | Record<string, any>, data?: Record<string, any>): void {
+    let errorData: Record<string, any> | undefined;
+    if (errorOrData instanceof Error) {
+      errorData = { ...data, error: errorOrData.message, stack: errorOrData.stack };
+    } else {
+      errorData = errorOrData;
+    }
+    Logger.instance?.log(LogLevel.WARN, context, message, errorData);
   }
 
   static error(context: string, message: string, error?: Error, data?: Record<string, any>): void {

src/protocol/node-store.ts

@@ -68,12 +68,12 @@ export class NodeStore {
       userId: info.user?.id || existing.userId,
       longName: info.user?.longName || existing.longName,
       shortName: info.user?.shortName || existing.shortName,
-      hwModel: info.user?.hwModel || existing.hwModel,
+      hwModel: info.user?.hwModel ?? existing.hwModel,
       publicKey: info.user?.publicKey?.length ? info.user.publicKey : existing.publicKey,
       latitudeI: info.position?.latitudeI ?? existing.latitudeI,
       longitudeI: info.position?.longitudeI ?? existing.longitudeI,
       altitude: info.position?.altitude ?? existing.altitude,
-      snr: info.snr || existing.snr,
+      snr: info.snr ?? existing.snr,
       lastHeard: info.lastHeard || existing.lastHeard || Date.now() / 1000,
       batteryLevel: info.deviceMetrics?.batteryLevel ?? existing.batteryLevel,
       voltage: info.deviceMetrics?.voltage ?? existing.voltage,
@@ -96,7 +96,7 @@ export class NodeStore {
       userId: user.id || existing.userId,
       longName: user.longName || existing.longName,
       shortName: user.shortName || existing.shortName,
-      hwModel: user.hwModel || existing.hwModel,
+      hwModel: user.hwModel ?? existing.hwModel,
       role: user.role ?? existing.role,
       publicKey: user.publicKey?.length ? user.publicKey : existing.publicKey,
       lastHeard: Date.now() / 1000,