feat: source Node version from package.json#engines (#66)

Author: marcalexiei

.github/actions/install-dependencies/action.yml

@@ -7,7 +7,7 @@ description: |
 
 inputs:
   node-version:
-    description: "Explicit node version. Otherwise fallback reading `.nvmrc`"
+    description: "Explicit node version. Otherwise fallback reading `engines.node` in `package.json`"
 
 runs:
   using: composite
@@ -24,11 +24,11 @@ runs:
         cache: "pnpm"
         registry-url: "https://registry.npmjs.org"
 
-    - name: Setup Node.js (via .nvmrc)
+    - name: Setup Node.js (via package.json engines)
       if: ${{ !inputs.node-version }}
       uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
       with:
-        node-version-file: ".nvmrc"
+        node-version-file: "package.json"
         cache: "pnpm"
         registry-url: "https://registry.npmjs.org"
 

.github/workflows/ci.yml

@@ -17,12 +17,11 @@ permissions: {}
 
 jobs:
   test:
-    name: Test ${{ matrix.node }} on ${{ matrix.os }}
+    name: Test on ${{ matrix.os }}
 
     strategy:
       fail-fast: false
       matrix:
-        node: [24]
         os: [ubuntu-latest, macos-latest]
     runs-on: ${{ matrix.os }}
 
@@ -35,8 +34,6 @@ jobs:
 
       - name: Install Dependencies
         uses: ./.github/actions/install-dependencies
-        with:
-          node-version: ${{ matrix.node }}
 
       - name: Run E2E tests
         run: pnpm run test

.nvmrc

@@ -1 +1,2 @@
+# Source of truth: package.json engines.node — keep this file aligned
 24

action.yml

@@ -28,18 +28,21 @@ outputs:
 runs:
   using: composite
   steps:
-    - name: Resolve relative path to package.json
+    # pnpm/action-setup's `package_json_file` and setup-node's `node-version-file` are both
+    # resolved relative to $GITHUB_WORKSPACE, but our package.json lives under
+    # ${{ github.action_path }} — convert to a workspace-relative path.
+    - name: Compute workspace-relative package.json path
       id: resolve_path
       run: echo "package_json=$(realpath --relative-to="$GITHUB_WORKSPACE" "${{ github.action_path }}/package.json")" >> "$GITHUB_OUTPUT"
       shell: bash
     - name: Install pnpm
-      uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v5
+      uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v5.0.0
       with:
         package_json_file: ${{ steps.resolve_path.outputs.package_json }}
     - name: Setup Node.js
       uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
       with:
-        node-version: "24"
+        node-version-file: ${{ steps.resolve_path.outputs.package_json }}
     - name: Install dependencies
       # --prod skips devDependencies (husky, vitest, etc.); --ignore-scripts skips the
       # husky prepare hook, which would otherwise fail since husky isn't installed.

package.json

@@ -29,6 +29,6 @@
     "*.{js,jsx,ts,tsx,css,json,jsonc,yaml,yml}": "prettier --write"
   },
   "engines": {
-    "node": ">=24"
+    "node": "24.x"
   }
 }