feat: add fail_on_error input#100
Merged
Merged
Conversation
marcalexiei
commented
Jul 19, 2026
Comment on lines
-184
to
-186
| const optionsInput = getInput("options") || ""; | ||
| const optionsInput = getInput("options"); | ||
| const outputPathInput = getInput("path"); | ||
| const coreVersion = validateCoreVersion(getInput("core_version") || ""); |
Contributor
Author
There was a problem hiding this comment.
I removed the || "" since the getInput JSDoc states:
Returns an empty string if the value is not defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The renderer returns a "Something went wrong" SVG on fetch failures instead of throwing, so the action used to exit green with a broken card.
Adds an opt-in
fail_on_errorinput (defaultfalse).When
true, the action fails on an errorstatusinstead of writing the card.Default is unchanged; this behaviour is backwards compatible.
action.yml: new input, wired toINPUT_FAIL_ON_ERRORindex.js:setFailedon error status when enabledREADME.md: document the inputtests/e2e.test.js: cover fail path and default write path