Skip to content

align with github-stats-extended#22

Merged
martin-mfg merged 5 commits intomainfrom
gse-alignment
Apr 12, 2026
Merged

align with github-stats-extended#22
martin-mfg merged 5 commits intomainfrom
gse-alignment

Conversation

@martin-mfg
Copy link
Copy Markdown
Member

Aligning some aspects of the general setup with https://github.com/stats-organization/github-stats-extended so that the projects are more similar to each other and it's easier to work on them in parallel.

@martin-mfg martin-mfg requested a review from marcalexiei April 11, 2026 08:48
Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
Comment thread tests/e2e.test.js Outdated
Comment thread vitest.config.ts Outdated
Comment thread package-lock.json Outdated
Comment thread package.json
Comment on lines 20 to +25
"devDependencies": {
"husky": "^9.0.11",
"jest": "^29.7.0",
"knip": "6.2.0",
"lint-staged": "^15.2.7",
"prettier": "^3.3.3"
"prettier": "^3.3.3",
"vitest": "4.1.2"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I would consider using exact match for every dev dependency listed here

Copy link
Copy Markdown
Member Author

@martin-mfg martin-mfg Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done via latest commit. Why do you recommend exact matches only for dev dependencies and not for regular dependencies though? And how about GitHub workflow inclusions (uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2)?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you recommend exact matches only for dev dependencies and not for regular dependencies though?

I pin devDependencies so I always know the exact versions in use without needing to run commands like pnpm ls.
I don’t pin dependencies so that, if a security issue arises, consumers don’t have to wait for a new release with updated pinned versions.


And how about GitHub workflow inclusions

Recently, I’ve noticed more repositories using hashes instead of tags.
The reason is that a hash is immutable, whereas a tag is not, making hashes a more secure option.

@martin-mfg martin-mfg requested a review from marcalexiei April 11, 2026 13:32
@martin-mfg martin-mfg merged commit 219db02 into main Apr 12, 2026
5 checks passed
@martin-mfg martin-mfg deleted the gse-alignment branch April 12, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants