feat(core): migrate cards/gist to TypeScript#365
Closed
shaurya-sharma-dev wants to merge 2 commits into
Closed
Conversation
|
@shaurya-sharma-dev is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
marcalexiei
reviewed
Jul 16, 2026
Comment on lines
+132
to
+136
| // @ts-expect-error Stops TypeScript from raising error. | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment -- Suppressing the resulting error-any | ||
| const languageColor = languageColors[languageName] || "#858585"; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-argument -- Suppressing the resulting error-any |
There was a problem hiding this comment.
FYI the three suppressions have the same root cause: languageColors.json is inferred with literal keys and no index signature, so languageColors[languageName] causes a type error.
Casting languageName to the correct key type would remove the need for all three suppressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests continues #140 by migrating cards/gist to TypeScript.
Note: There was an error where TypeScript raised the following error:
To fix this, I modified common/Card.ts to add
| undefinedto theborder_radiusparameter typehint.(Edit: Separate error message more clearly.)