feat(core): start fetchers TypeScript migration (retryer generic + gist)#370
Open
marcalexiei wants to merge 1 commit into
Open
feat(core): start fetchers TypeScript migration (retryer generic + gist)#370marcalexiei wants to merge 1 commit into
marcalexiei wants to merge 1 commit into
Conversation
|
@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
marcalexiei
commented
Jul 16, 2026
| "editor.formatOnSave": true, | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "[javascript]": { | ||
| "editor.tabSize": 2, |
Author
There was a problem hiding this comment.
I removed this line since it's redundant with the repository prettier config:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step of #140, continues #322.
Starts migrating
fetchers/.retryeris now generic over the response payload:retryer<TData>(…)returnsAxiosResponse<TData & ResponseErrors>so callers get their ownresponse.datashape while the retryer still readserrors/message.Defaults to
unknownso existing callers are unaffected.src/fetchers/types.d.ts➡️types.ts(references are extensionless, so they resolve unchanged).gistfetcher + test ➡️.ts, usingretryer<GistQueryResponse>(…).