Skip to content

StatusMessage: quote blocks handling improvements#21108

Open
micieslak wants to merge 7 commits into
release/2.38.xfrom
fix/issue-20801-block-quotes
Open

StatusMessage: quote blocks handling improvements#21108
micieslak wants to merge 7 commits into
release/2.38.xfrom
fix/issue-20801-block-quotes

Conversation

@micieslak
Copy link
Copy Markdown
Member

@micieslak micieslak commented Jun 2, 2026

What does the PR do

This PR improves rendering of quote blocks in StatusMessage:

  • ability to mix quote blocks and other content withing single message
  • ability to have multiple quote blocks within single message, every block has properly rendered vertical bar decorating quote block
  • new lines in quote blocks are correctly preserved

Closes: #20801

Affected areas

StatusTextMessage

Quality checklist

Screencapture of the functionality

Screencast.from.02.06.2026.16.14.33.webm

Impact on end user

Medium

How to test

Go to chat, use multiple quote blocks mixed up with other content within single message.

Risk

Low

@micieslak micieslak requested review from a team, alexjba, caybro and noeliaSD as code owners June 2, 2026 14:16
@micieslak micieslak requested review from anastasiyaig and dlipicar and removed request for a team June 2, 2026 14:16
@micieslak micieslak changed the base branch from master to release/2.38.x June 2, 2026 14:17
@status-im-auto
Copy link
Copy Markdown
Member

status-im-auto commented Jun 2, 2026

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5c8dcec 2 2026-06-02 14:25:40 ~8 min tests/nim 📄log
✔️ 5c8dcec 2 2026-06-02 14:30:12 ~12 min tests/ui 📄log
✔️ 5c8dcec 2 2026-06-02 14:30:51 ~13 min ios/aarch64 📱ipa 📲
✔️ 5c8dcec 2 2026-06-02 14:34:27 ~16 min linux/x86_64 📦tgz
✔️ 5c8dcec 1 2026-06-02 14:35:49 ~18 min macos/aarch64 🍎dmg
✔️ 5c8dcec 1 2026-06-02 14:40:27 ~22 min windows/x86_64 💿exe
✖️ 5c8dcec 11551 2026-06-02 14:50:58 ~16 min tests/e2e 📊rpt
✖️ 5c8dcec 3485 2026-06-02 15:15:33 ~34 min tests/e2e-windows 📊rpt
✖️ 5c8dcec 3641 2026-06-02 15:53:53 ~1 hr 26 min tests/e2e-android 📦pkg
✔️ e8c5b54d 1 2026-06-02 14:27:28 ~9 min android/arm64 🤖apk 📲

// which need StatusTextArea (textDocument/positionToRectangle) to draw the
// quote bar. Desktop always uses StatusTextArea to allow selection by mouse.
sourceComponent: (root.isMobile && !d.hasBlockQuote) ? chatTextMobileComp
: chatTextDesktopComp
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the context menus though on mobile

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which menus? I tested it all and haven't spotted anything suspicious 🤔

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you long press on a text message on mobile; and especially then when you scroll through messages; see the original issue: #20360 and the corresponding PR: #21022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chat input] Quote feature doesn't work correctly if you have quoted and not quoted text in a message

3 participants