Auto-generated commit

Author: stdlib-bot

CHANGELOG.md

@@ -17,12 +17,23 @@
 
 <!-- /.features -->
 
+<section class="bug-fixes">
+
+### Bug Fixes
+
+-   [`c9f4cb9`](https://github.com/stdlib-js/stdlib/commit/c9f4cb9b593f963d25efc20a6bd3b2aeeda515c2) - add missing checks and tests
+
+</section>
+
+<!-- /.bug-fixes -->
+
 <section class="commits">
 
 ### Commits
 
 <details>
 
+-   [`c9f4cb9`](https://github.com/stdlib-js/stdlib/commit/c9f4cb9b593f963d25efc20a6bd3b2aeeda515c2) - **fix:** add missing checks and tests _(by Athan Reines)_
 -   [`fffbf73`](https://github.com/stdlib-js/stdlib/commit/fffbf730b1a27175ece26a82f05c4053567e4386) - **feat:** add C implementation for `blas/base/dsyr`  [(#6566)](https://github.com/stdlib-js/stdlib/pull/6566) _(by Shabareesh Shetty, Athan Reines)_
 -   [`6555228`](https://github.com/stdlib-js/stdlib/commit/65552285402918e100f9562cdef24493fc43550a) - **test:** add test cases for `blas/base/dsyr` [(#7128)](https://github.com/stdlib-js/stdlib/pull/7128) _(by Shabareesh Shetty)_
 -   [`dfa9446`](https://github.com/stdlib-js/stdlib/commit/dfa944638baf665a4f16321a88ffd5091b2b14fb) - **refactor:** use base assertion utility _(by Athan Reines)_

lib/ndarray.native.js

@@ -44,6 +44,8 @@ var addon = require( './../src/addon.node' );
 * @throws {TypeError} first argument must specify whether to reference the lower or upper triangular matrix
 * @throws {RangeError} second argument must be a nonnegative integer
 * @throws {RangeError} fifth argument must be non-zero
+* @throws {RangeError} eighth argument must be non-zero
+* @throws {RangeError} ninth argument must be non-zero
 * @returns {Float64Array} `A`
 *
 * @example
@@ -65,6 +67,12 @@ function dsyr( uplo, N, alpha, x, strideX, offsetX, A, strideA1, strideA2, offse
 	if ( strideX === 0 ) {
 		throw new RangeError( format( 'invalid argument. Fifth argument must be non-zero. Value: `%d`.', strideX ) );
 	}
+	if ( strideA1 === 0 ) {
+		throw new RangeError( format( 'invalid argument. Eighth argument must be non-zero. Value: `%d`.', strideA1 ) );
+	}
+	if ( strideA2 === 0 ) {
+		throw new RangeError( format( 'invalid argument. Ninth argument must be non-zero. Value: `%d`.', strideA2 ) );
+	}
 	// Check if we can early return...
 	if ( N === 0 || alpha === 0.0 ) {
 		return A;

test/test.ndarray.native.js

@@ -35,6 +35,7 @@ var rl = require( './fixtures/row_major_l.json' );
 var rxp = require( './fixtures/row_major_xp.json' );
 var rxn = require( './fixtures/row_major_xn.json' );
 var roa = require( './fixtures/row_major_oa.json' );
+var rox = require( './fixtures/row_major_ox.json' );
 var rsa1sa2 = require( './fixtures/row_major_sa1_sa2.json' );
 var rsa1nsa2 = require( './fixtures/row_major_sa1n_sa2.json' );
 var rsa1sa2n = require( './fixtures/row_major_sa1_sa2n.json' );
@@ -46,6 +47,7 @@ var cl = require( './fixtures/column_major_l.json' );
 var cxp = require( './fixtures/column_major_xp.json' );
 var cxn = require( './fixtures/column_major_xn.json' );
 var coa = require( './fixtures/column_major_oa.json' );
+var cox = require( './fixtures/column_major_ox.json' );
 var csa1sa2 = require( './fixtures/column_major_sa1_sa2.json' );
 var csa1nsa2 = require( './fixtures/column_major_sa1n_sa2.json' );
 var csa1sa2n = require( './fixtures/column_major_sa1_sa2n.json' );
@@ -148,6 +150,52 @@ tape( 'the function throws an error if provided an invalid fifth argument', opts
 	}
 });
 
+tape( 'the function throws an error if provided an invalid eighth argument', opts, function test( t ) {
+	var values;
+	var data;
+	var i;
+
+	data = ru;
+
+	values = [
+		0
+	];
+
+	for ( i = 0; i < values.length; i++ ) {
+		t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
+	}
+	t.end();
+
+	function badValue( value ) {
+		return function badValue() {
+			dsyr( data.uplo, data.N, data.alpha, new Float64Array( data.x ), data.strideX, data.offsetX, new Float64Array( data.A ), value, data.strideA2, data.offsetA );
+		};
+	}
+});
+
+tape( 'the function throws an error if provided an invalid ninth argument', opts, function test( t ) {
+	var values;
+	var data;
+	var i;
+
+	data = ru;
+
+	values = [
+		0
+	];
+
+	for ( i = 0; i < values.length; i++ ) {
+		t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
+	}
+	t.end();
+
+	function badValue( value ) {
+		return function badValue() {
+			dsyr( data.uplo, data.N, data.alpha, new Float64Array( data.x ), data.strideX, data.offsetX, new Float64Array( data.A ), data.strideA1, value, data.offsetA );
+		};
+	}
+});
+
 tape( 'the function performs the symmetric rank 1 operation `A = α*x*x^T + A` (row-major, upper)', opts, function test( t ) {
 	var expected;
 	var data;
@@ -593,6 +641,48 @@ tape( 'the function supports specifying a negative `x` stride (column-major)', o
 	t.end();
 });
 
+tape( 'the function supports specifying an `x` offset (row-major)', opts, function test( t ) {
+	var expected;
+	var data;
+	var out;
+	var a;
+	var x;
+
+	data = rox;
+
+	a = new Float64Array( data.A );
+	x = new Float64Array( data.x );
+
+	expected = new Float64Array( data.A_out );
+
+	out = dsyr( data.uplo, data.N, data.alpha, x, data.strideX, data.offsetX, a, data.strideA1, data.strideA2, data.offsetA );
+	t.strictEqual( out, a, 'returns expected value' );
+	t.deepEqual( out, expected, 'returns expected value' );
+
+	t.end();
+});
+
+tape( 'the function supports specifying an `x` offset (column-major)', opts, function test( t ) {
+	var expected;
+	var data;
+	var out;
+	var a;
+	var x;
+
+	data = cox;
+
+	a = new Float64Array( data.A );
+	x = new Float64Array( data.x );
+
+	expected = new Float64Array( data.A_out );
+
+	out = dsyr( data.uplo, data.N, data.alpha, x, data.strideX, data.offsetX, a, data.strideA1, data.strideA2, data.offsetA );
+	t.strictEqual( out, a, 'returns expected value' );
+	t.deepEqual( out, expected, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'the function supports complex access patterns (row-major)', opts, function test( t ) {
 	var expected;
 	var data;