Auto-generated commit

Author: stdlib-bot

CHANGELOG.md

@@ -432,6 +432,7 @@
 
 ### Bug Fixes
 
+-   [`b7368a4`](https://github.com/stdlib-js/stdlib/commit/b7368a45d5b0cc0bbdf695291837eee3d726da0a) - handle edge case when provided an empty ndarray
 -   [`f84c1a6`](https://github.com/stdlib-js/stdlib/commit/f84c1a6ecbaf68b7dfbeef4576111bc277885d1a) - remove unused parameter
 -   [`2848c77`](https://github.com/stdlib-js/stdlib/commit/2848c77bb0cf8fd2fc78fe72095a1aad2e545a36) - improve type specificity, remove unreachable path, and fix docs
 -   [`5b491c9`](https://github.com/stdlib-js/stdlib/commit/5b491c98f454c2413c23eaa901543bef9e3642f2) - allow enums to be nonpositive integers
@@ -594,6 +595,7 @@ A total of 25 issues were closed in this release:
 
 <details>
 
+-   [`b7368a4`](https://github.com/stdlib-js/stdlib/commit/b7368a45d5b0cc0bbdf695291837eee3d726da0a) - **fix:** handle edge case when provided an empty ndarray _(by Athan Reines)_
 -   [`2798013`](https://github.com/stdlib-js/stdlib/commit/2798013a8edf4eb58a762928e8625089eef0f4f5) - **docs:** update example _(by Athan Reines)_
 -   [`4dba8a6`](https://github.com/stdlib-js/stdlib/commit/4dba8a659480c7c39382084ba3bb7fdace936609) - **chore:** fix JavaScript lint errors [(#8134)](https://github.com/stdlib-js/stdlib/pull/8134) _(by Payal Goswami, Athan Reines)_
 -   [`fa53483`](https://github.com/stdlib-js/stdlib/commit/fa534835906f659a1b322a1c2e5c7e3328db43ce) - **docs:** update Markdown stdlib package URLs [(#8131)](https://github.com/stdlib-js/stdlib/pull/8131) _(by stdlib-bot)_

base/pop/lib/main.js

@@ -89,10 +89,10 @@ function pop( x, dim, writable ) {
 	s[ dim ] = sh[ dim ] - 1;
 
 	// Create a truncated view:
-	v0 = sliceTo( x, s, true, writable );
+	v0 = sliceTo( x, s, false, writable );
 
 	// Create a view of the last element(s):
-	v1 = sliceFrom( x, s, true, writable );
+	v1 = sliceFrom( x, s, false, writable );
 
 	return [ v0, v1 ];
 }

base/pop/test/test.js

@@ -356,3 +356,70 @@ tape( 'the function returns an array containing ndarrays (ndims=3, writable)', f
 
 	t.end();
 });
+
+tape( 'the function returns empty views if provided an empty array (ndims=2)', function test( t ) {
+	var actual;
+	var buf;
+	var ord;
+	var sh;
+	var st;
+	var o;
+	var x;
+
+	buf = zeroTo( 8, 'float64' );
+	st = [ 4, 1 ];
+	o = 0;
+	ord = 'row-major';
+
+	sh = [ 2, 0 ];
+	x = new ndarray( 'float64', buf, sh, st, o, ord );
+
+	actual = pop( x, 0, false );
+
+	t.strictEqual( isndarrayLike( actual[0] ), true, 'returns expected value' );
+	t.strictEqual( isndarrayLike( actual[1] ), true, 'returns expected value' );
+	t.strictEqual( isReadOnly( actual[0] ), true, 'returns expected value' );
+	t.strictEqual( isReadOnly( actual[1] ), true, 'returns expected value' );
+	t.deepEqual( getShape( actual[0] ), [ 1, 0 ], 'returns expected value' );
+	t.deepEqual( getShape( actual[1] ), [ 1, 0 ], 'returns expected value' );
+	t.deepEqual( ndarray2array( actual[0] ), [], 'returns expected value' );
+	t.deepEqual( ndarray2array( actual[1] ), [], 'returns expected value' );
+
+	actual = pop( x, 1, false );
+
+	t.strictEqual( isndarrayLike( actual[0] ), true, 'returns expected value' );
+	t.strictEqual( isndarrayLike( actual[1] ), true, 'returns expected value' );
+	t.strictEqual( isReadOnly( actual[0] ), true, 'returns expected value' );
+	t.strictEqual( isReadOnly( actual[1] ), true, 'returns expected value' );
+	t.deepEqual( getShape( actual[0] ), [ 2, 0 ], 'returns expected value' );
+	t.deepEqual( getShape( actual[1] ), [ 2, 0 ], 'returns expected value' );
+	t.deepEqual( ndarray2array( actual[0] ), [], 'returns expected value' );
+	t.deepEqual( ndarray2array( actual[1] ), [], 'returns expected value' );
+
+	sh = [ 0, 4 ];
+	x = new ndarray( 'float64', buf, sh, st, o, ord );
+
+	actual = pop( x, 0, false );
+
+	t.strictEqual( isndarrayLike( actual[0] ), true, 'returns expected value' );
+	t.strictEqual( isndarrayLike( actual[1] ), true, 'returns expected value' );
+	t.strictEqual( isReadOnly( actual[0] ), true, 'returns expected value' );
+	t.strictEqual( isReadOnly( actual[1] ), true, 'returns expected value' );
+	t.deepEqual( getShape( actual[0] ), [ 0, 4 ], 'returns expected value' );
+	t.deepEqual( getShape( actual[1] ), [ 0, 4 ], 'returns expected value' );
+	t.deepEqual( ndarray2array( actual[0] ), [], 'returns expected value' );
+	t.deepEqual( ndarray2array( actual[1] ), [], 'returns expected value' );
+
+	actual = pop( x, 1, false );
+
+	t.strictEqual( isndarrayLike( actual[0] ), true, 'returns expected value' );
+	t.strictEqual( isndarrayLike( actual[1] ), true, 'returns expected value' );
+	t.strictEqual( isReadOnly( actual[0] ), true, 'returns expected value' );
+	t.strictEqual( isReadOnly( actual[1] ), true, 'returns expected value' );
+	t.deepEqual( getShape( actual[0] ), [ 0, 3 ], 'returns expected value' );
+	t.deepEqual( getShape( actual[1] ), [ 0, 1 ], 'returns expected value' );
+	t.deepEqual( ndarray2array( actual[0] ), [], 'returns expected value' );
+	t.deepEqual( ndarray2array( actual[1] ), [], 'returns expected value' );
+
+	t.end();
+});