Auto-generated commit

Author: stdlib-bot

CHANGELOG.md

@@ -251,6 +251,7 @@
 
 ### Bug Fixes
 
+-   [`ab22671`](https://github.com/stdlib-js/stdlib/commit/ab2267149121cf347c5be11d7bfc7ee64e4f663a) - use resolved order when computing loop variables
 -   [`18036a4`](https://github.com/stdlib-js/stdlib/commit/18036a4b73cbae2f90f5ce929645d1eb769138dc) - use resolved order when determining increment offsets
 -   [`3ce09af`](https://github.com/stdlib-js/stdlib/commit/3ce09af9819ae7dbaad178179264fc84c5db5690) - ensure separate array instance for each memory layout
 -   [`7c29c2d`](https://github.com/stdlib-js/stdlib/commit/7c29c2d3aea7b8d0396a77f6781d7d76bd7adde4) - use computed order
@@ -352,6 +353,10 @@ A total of 14 issues were closed in this release:
 
 <details>
 
+-   [`25f29f8`](https://github.com/stdlib-js/stdlib/commit/25f29f85b888fd71646902ad9cda4f5f6aa62eff) - **refactor:** use base assertion utility _(by Athan Reines)_
+-   [`3088dea`](https://github.com/stdlib-js/stdlib/commit/3088deabee417ce890ccb15e87066ef11c3f2305) - **test:** fix lint errors _(by Athan Reines)_
+-   [`b9d3f03`](https://github.com/stdlib-js/stdlib/commit/b9d3f03a8fc45fa0f65dc1ded1a5b40125a0a0fb) - **refactor:** use base assertion utility _(by Athan Reines)_
+-   [`ab22671`](https://github.com/stdlib-js/stdlib/commit/ab2267149121cf347c5be11d7bfc7ee64e4f663a) - **fix:** use resolved order when computing loop variables _(by Athan Reines)_
 -   [`18036a4`](https://github.com/stdlib-js/stdlib/commit/18036a4b73cbae2f90f5ce929645d1eb769138dc) - **fix:** use resolved order when determining increment offsets _(by Athan Reines)_
 -   [`ac7d5b4`](https://github.com/stdlib-js/stdlib/commit/ac7d5b41eeefdc2a27ffeb244442c2e29feb728c) - **refactor:** use assertion utility rather than hardcoded string _(by Athan Reines)_
 -   [`2464b78`](https://github.com/stdlib-js/stdlib/commit/2464b78c6e164fd048d04d13d57a3ba44707cac9) - **docs:** remove import _(by Athan Reines)_

array/lib/expand_strides.js

@@ -20,6 +20,7 @@
 
 // MODULES //
 
+var isRowMajor = require( './../../base/assert/is-row-major-string' );
 var abs = require( '@stdlib/math/base/special/abs' );
 
 
@@ -53,7 +54,7 @@ function expandStrides( ndims, shape, strides, order ) {
 	N = strides.length;
 	j = ndims - N;
 	out = [];
-	if ( order === 'row-major' ) {
+	if ( isRowMajor( order ) ) {
 		s = abs( strides[ 0 ] ) * shape[ j ]; // at `j` is the size of the first non-prepended dimension
 		for ( i = 0; i < j; i++ ) {
 			out.push( s );

base/assign/lib/10d.js

@@ -40,6 +40,7 @@
 * @param {IntegerArray} y.strides - stride lengths
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @returns {void}
 *
 * @example
@@ -79,12 +80,12 @@
 * };
 *
 * // Copy elements:
-* assign10d( x, y );
+* assign10d( x, y, true );
 *
 * console.log( y.data );
 * // => <Float64Array>[ 2.0, 3.0, 6.0, 7.0, 10.0, 11.0 ]
 */
-function assign10d( x, y ) { // eslint-disable-line max-statements
+function assign10d( x, y, isRowMajor ) { // eslint-disable-line max-statements
 	var xbuf;
 	var ybuf;
 	var dx0;
@@ -139,7 +140,7 @@ function assign10d( x, y ) { // eslint-disable-line max-statements
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( x.order === 'row-major' ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 9 ];
 		S1 = sh[ 8 ];

base/assign/lib/10d_accessors.js

@@ -42,6 +42,7 @@
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
 * @param {Array<Function>} y.accessors - data buffer accessors
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @returns {void}
 *
 * @example
@@ -95,7 +96,7 @@
 * };
 *
 * // Copy elements:
-* assign10d( x, y );
+* assign10d( x, y, true );
 *
 * var v = y.data.get( 0 );
 *
@@ -105,7 +106,7 @@
 * var im = imagf( v );
 * // returns 2.0
 */
-function assign10d( x, y ) { // eslint-disable-line max-statements
+function assign10d( x, y, isRowMajor ) { // eslint-disable-line max-statements
 	var xbuf;
 	var ybuf;
 	var get;
@@ -162,7 +163,7 @@ function assign10d( x, y ) { // eslint-disable-line max-statements
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( x.order === 'row-major' ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 9 ];
 		S1 = sh[ 8 ];

base/assign/lib/2d.js

@@ -38,6 +38,7 @@
 * @param {IntegerArray} y.strides - stride lengths
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @returns {void}
 *
 * @example
@@ -77,12 +78,12 @@
 * };
 *
 * // Copy elements:
-* assign2d( x, y );
+* assign2d( x, y, true );
 *
 * console.log( y.data );
 * // => <Float64Array>[ 2.0, 3.0, 6.0, 7.0 ]
 */
-function assign2d( x, y ) {
+function assign2d( x, y, isRowMajor ) {
 	var xbuf;
 	var ybuf;
 	var dx0;
@@ -105,7 +106,7 @@ function assign2d( x, y ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( x.order === 'row-major' ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 1 ];
 		S1 = sh[ 0 ];

base/assign/lib/2d_accessors.js

@@ -40,6 +40,7 @@
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
 * @param {Array<Function>} y.accessors - data buffer accessors
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @returns {void}
 *
 * @example
@@ -93,7 +94,7 @@
 * };
 *
 * // Copy elements:
-* assign2d( x, y );
+* assign2d( x, y, true );
 *
 * var v = y.data.get( 0 );
 *
@@ -103,7 +104,7 @@
 * var im = imagf( v );
 * // returns 2.0
 */
-function assign2d( x, y ) {
+function assign2d( x, y, isRowMajor ) {
 	var xbuf;
 	var ybuf;
 	var get;
@@ -128,7 +129,7 @@ function assign2d( x, y ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( x.order === 'row-major' ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 1 ];
 		S1 = sh[ 0 ];

base/assign/lib/3d.js

@@ -38,6 +38,7 @@
 * @param {IntegerArray} y.strides - stride lengths
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @returns {void}
 *
 * @example
@@ -77,12 +78,12 @@
 * };
 *
 * // Copy elements:
-* assign3d( x, y );
+* assign3d( x, y, true );
 *
 * console.log( y.data );
 * // => <Float64Array>[ 2.0, 3.0, 6.0, 7.0, 10.0, 11.0 ]
 */
-function assign3d( x, y ) {
+function assign3d( x, y, isRowMajor ) {
 	var xbuf;
 	var ybuf;
 	var dx0;
@@ -109,7 +110,7 @@ function assign3d( x, y ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( x.order === 'row-major' ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 2 ];
 		S1 = sh[ 1 ];

base/assign/lib/3d_accessors.js

@@ -40,6 +40,7 @@
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
 * @param {Array<Function>} y.accessors - data buffer accessors
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @returns {void}
 *
 * @example
@@ -93,7 +94,7 @@
 * };
 *
 * // Copy elements:
-* assign3d( x, y );
+* assign3d( x, y, true );
 *
 * var v = y.data.get( 0 );
 *
@@ -103,7 +104,7 @@
 * var im = imagf( v );
 * // returns 2.0
 */
-function assign3d( x, y ) {
+function assign3d( x, y, isRowMajor ) {
 	var xbuf;
 	var ybuf;
 	var get;
@@ -132,7 +133,7 @@ function assign3d( x, y ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( x.order === 'row-major' ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 2 ];
 		S1 = sh[ 1 ];

base/assign/lib/4d.js

@@ -38,6 +38,7 @@
 * @param {IntegerArray} y.strides - stride lengths
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @returns {void}
 *
 * @example
@@ -77,12 +78,12 @@
 * };
 *
 * // Copy elements:
-* assign4d( x, y );
+* assign4d( x, y, true );
 *
 * console.log( y.data );
 * // => <Float64Array>[ 2.0, 3.0, 6.0, 7.0, 10.0, 11.0 ]
 */
-function assign4d( x, y ) {
+function assign4d( x, y, isRowMajor ) {
 	var xbuf;
 	var ybuf;
 	var dx0;
@@ -113,7 +114,7 @@ function assign4d( x, y ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( x.order === 'row-major' ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 3 ];
 		S1 = sh[ 2 ];

base/assign/lib/4d_accessors.js

@@ -40,6 +40,7 @@
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
 * @param {Array<Function>} y.accessors - data buffer accessors
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @returns {void}
 *
 * @example
@@ -93,7 +94,7 @@
 * };
 *
 * // Copy elements:
-* assign4d( x, y );
+* assign4d( x, y, true );
 *
 * var v = y.data.get( 0 );
 *
@@ -103,7 +104,7 @@
 * var im = imagf( v );
 * // returns 2.0
 */
-function assign4d( x, y ) {
+function assign4d( x, y, isRowMajor ) {
 	var xbuf;
 	var ybuf;
 	var get;
@@ -136,7 +137,7 @@ function assign4d( x, y ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( x.order === 'row-major' ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 3 ];
 		S1 = sh[ 2 ];