Auto-generated commit

Author: stdlib-bot

CHANGELOG.md

@@ -556,6 +556,7 @@
 
 ### Bug Fixes
 
+-   [`eab49ad`](https://github.com/stdlib-js/stdlib/commit/eab49ad435f6080ec28a8fbb75de4d9520bdd7e4) - ensure support for elements which are null or undefined
 -   [`f10a6aa`](https://github.com/stdlib-js/stdlib/commit/f10a6aaf98c37bb630ac75e1a50dd0bd4a0eb417) - ensure unique indices
 -   [`11cc2cf`](https://github.com/stdlib-js/stdlib/commit/11cc2cf8869a4b6ebf48545d5678eda25513529e) - use ndarray assertion utility
 -   [`6c43167`](https://github.com/stdlib-js/stdlib/commit/6c4316733d615b06d301eec89c377838a6b56dd8) - resolve normalized data type
@@ -783,6 +784,7 @@ A total of 44 issues were closed in this release:
 
 <details>
 
+-   [`eab49ad`](https://github.com/stdlib-js/stdlib/commit/eab49ad435f6080ec28a8fbb75de4d9520bdd7e4) - **fix:** ensure support for elements which are null or undefined _(by Athan Reines)_
 -   [`7f1f9ca`](https://github.com/stdlib-js/stdlib/commit/7f1f9cae7096b100fb0d2fafdb6822545bd0489a) - **test:** fix missing argument in TypeScript test _(by Philipp Burckhardt)_
 -   [`5ff8528`](https://github.com/stdlib-js/stdlib/commit/5ff852828a9f5d0388ef386f039649d95987252d) - **chore:** minor clean-up _(by Philipp Burckhardt)_
 -   [`98b02ad`](https://github.com/stdlib-js/stdlib/commit/98b02adb85c1a0644510dddd2fab2c1b6b61c2eb) - **feat:** update `ndarray/base` TypeScript declarations [(#10584)](https://github.com/stdlib-js/stdlib/pull/10584) _(by stdlib-bot)_

base/ctor/lib/tolocalestring.js

@@ -23,6 +23,7 @@
 var isComplexDataType = require( './../../../base/assert/is-complex-floating-point-data-type' );
 var isString = require( '@stdlib/assert/is-string' ).isPrimitive;
 var isStringArray = require( '@stdlib/assert/is-string-array' ).primitives;
+var isUndefinedOrNull = require( '@stdlib/assert/is-undefined-or-null' );
 var isObject = require( '@stdlib/assert/is-plain-object' );
 var format = require( '@stdlib/string/format' );
 var replace = require( '@stdlib/string/replace' );
@@ -114,7 +115,12 @@ function toLocaleString( locales, options ) { // eslint-disable-line stdlib/no-r
 			}
 		} else {
 			for ( i = 0; i < this._length; i++ ) {
-				buffer += this.iget( i ).toLocaleString( loc, opts );
+				v = this.iget( i );
+				if ( !isUndefinedOrNull( v ) && v.toLocaleString ) {
+					buffer += v.toLocaleString( loc, opts );
+				} else {
+					buffer += String( v );
+				}
 				if ( i < this._length-1 ) {
 					buffer += ', ';
 				}
@@ -132,7 +138,12 @@ function toLocaleString( locales, options ) { // eslint-disable-line stdlib/no-r
 			}
 		} else {
 			for ( i = 0; i < 3; i++ ) {
-				buffer += this.iget( i ).toLocaleString( loc, opts );
+				v = this.iget( i );
+				if ( !isUndefinedOrNull( v ) && v.toLocaleString ) {
+					buffer += v.toLocaleString( loc, opts );
+				} else {
+					buffer += String( v );
+				}
 				if ( i < 2 ) {
 					buffer += ', ';
 				}
@@ -151,7 +162,12 @@ function toLocaleString( locales, options ) { // eslint-disable-line stdlib/no-r
 			}
 		} else {
 			for ( i = 2; i >= 0; i-- ) {
-				buffer += this.iget( this._length-1-i ).toLocaleString( loc, opts ); // eslint-disable-line max-len
+				v = this.iget( this._length-1-i );
+				if ( !isUndefinedOrNull( v ) && v.toLocaleString ) {
+					buffer += v.toLocaleString( loc, opts );
+				} else {
+					buffer += String( v );
+				}
 				if ( i > 0 ) {
 					buffer += ', ';
 				}

base/ctor/test/test.js

@@ -3810,6 +3810,37 @@ tape( 'an ndarray has a custom `toLocaleString()` method (boolean type)', functi
 	t.end();
 });
 
+tape( 'an ndarray has a custom `toLocaleString()` method (generic type)', function test( t ) {
+	var expected;
+	var strides;
+	var actual;
+	var buffer;
+	var offset;
+	var dtype;
+	var order;
+	var shape;
+	var arr;
+
+	dtype = 'generic';
+	buffer = [ null, void 0, null, void 0 ];
+	shape = [ 2, 2 ];
+	order = 'row-major';
+	strides = [ 2, 1 ];
+	offset = 0;
+
+	arr = ndarray( dtype, buffer, shape, strides, offset, order );
+
+	t.strictEqual( hasOwnProp( arr, 'toLocaleString' ), false, 'does not have own property' );
+	t.strictEqual( hasProp( arr, 'toLocaleString' ), true, 'has property' );
+	t.strictEqual( isFunction( arr.toLocaleString ), true, 'has method' );
+
+	expected = 'ndarray( \'generic\', [ null, undefined, null, undefined ], [ 2, 2 ], [ 2, 1 ], 0, \'row-major\' )';
+	actual = arr.toLocaleString();
+	t.strictEqual( actual, expected, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'an ndarray has a custom `toLocaleString()` method (0d)', function test( t ) {
 	var expected;
 	var strides;
@@ -3964,6 +3995,47 @@ tape( 'an ndarray has a custom `toLocaleString()` method (large array; complex t
 	t.end();
 });
 
+tape( 'an ndarray has a custom `toLocaleString()` method (large array; generic type)', function test( t ) {
+	var expected;
+	var strides;
+	var actual;
+	var buffer;
+	var offset;
+	var dtype;
+	var order;
+	var shape;
+	var arr;
+	var i;
+
+	dtype = 'generic';
+	buffer = [];
+	for ( i = 0; i < 10000; i++ ) {
+		if ( i < 3 ) {
+			buffer.push( null );
+		} else if ( i >= 9997 ) {
+			buffer.push( void 0 );
+		} else {
+			buffer.push( 0 );
+		}
+	}
+	shape = [ 10000 ];
+	order = 'row-major';
+	strides = [ 1 ];
+	offset = 0;
+
+	arr = ndarray( dtype, buffer, shape, strides, offset, order );
+
+	t.strictEqual( hasOwnProp( arr, 'toLocaleString' ), false, 'does not have own property' );
+	t.strictEqual( hasProp( arr, 'toLocaleString' ), true, 'has property' );
+	t.strictEqual( isFunction( arr.toLocaleString ), true, 'has method' );
+
+	expected = 'ndarray( \'generic\', [ null, null, null, ..., undefined, undefined, undefined ], [ 10000 ], [ 1 ], 0, \'row-major\' )';
+	actual = arr.toLocaleString();
+	t.strictEqual( actual, expected, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'an ndarray has a custom `toLocaleString()` method (locale, options)', function test( t ) {
 	var expected;
 	var strides;