Skip to content

Commit dadf61a

Browse files
committed
Auto-generated commit
1 parent ec98346 commit dadf61a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,7 @@
381381

382382
### Bug Fixes
383383

384+
- [`fd9991b`](https://github.com/stdlib-js/stdlib/commit/fd9991b94b618d3adfd81f177ddda412388bf1df) - remove conditional
384385
- [`6d74243`](https://github.com/stdlib-js/stdlib/commit/6d742438beb8e7fe0de4ecfbc82083da16a0a83c) - ensure correct type when providing a `dtype` option
385386
- [`57a9400`](https://github.com/stdlib-js/stdlib/commit/57a9400329d0570d2b25ad6b87d4d9a74d7fc28b) - avoid strict equality check
386387
- [`d5e1c28`](https://github.com/stdlib-js/stdlib/commit/d5e1c28e6821d21da0b79090ebd3cf903f036aae) - maintain floating-point precision
@@ -533,6 +534,7 @@ A total of 24 issues were closed in this release:
533534

534535
<details>
535536

537+
- [`fd9991b`](https://github.com/stdlib-js/stdlib/commit/fd9991b94b618d3adfd81f177ddda412388bf1df) - **fix:** remove conditional _(by Athan Reines)_
536538
- [`6fe6a73`](https://github.com/stdlib-js/stdlib/commit/6fe6a7362f3e6cc18790ee1c4f7388cbce187cb3) - **feat:** add `dtype` option support in `ndarray/flatten-by` [(#8094)](https://github.com/stdlib-js/stdlib/pull/8094) _(by Muhammad Haris, Athan Reines)_
537539
- [`9b660ce`](https://github.com/stdlib-js/stdlib/commit/9b660ceda07c2d62d1faccfe619da11579f631c6) - **test:** add `dtype` test _(by Athan Reines)_
538540
- [`6d74243`](https://github.com/stdlib-js/stdlib/commit/6d742438beb8e7fe0de4ecfbc82083da16a0a83c) - **fix:** ensure correct type when providing a `dtype` option _(by Athan Reines)_

base/some-by/lib/main.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,7 @@ function someBy( arrays, predicate, thisArg ) {
196196

197197
// Resolve the success criterion:
198198
N = n.accessors[ 0 ]( n.data, n.offset );
199-
if ( N < 1 ) {
200-
return true;
201-
}
199+
202200
// Determine whether we can avoid iteration altogether...
203201
if ( ndims === 0 ) {
204202
if ( x.accessorProtocol ) {

base/some-by/test/test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ tape( 'the function returns `false` if provided an empty input ndarray', functio
5656
}
5757
});
5858

59-
tape( 'the function returns `true` if a provided `n` parameter is less than zero', function test( t ) {
59+
tape( 'the function returns `false` if a provided `n` parameter is less than zero', function test( t ) {
6060
var actual;
6161
var x;
6262
var n;
@@ -67,7 +67,7 @@ tape( 'the function returns `true` if a provided `n` parameter is less than zero
6767
});
6868

6969
actual = someBy( [ x, n ], clbk );
70-
t.strictEqual( actual, true, 'returns expected value' );
70+
t.strictEqual( actual, false, 'returns expected value' );
7171

7272
t.end();
7373

0 commit comments

Comments
 (0)