fix: ensure consistency between asechf and asech tests

whizzel · whizzel · commit 08fc1fdac54e · 2026-03-09T13:07:17.000+05:30
diff --git a/lib/node_modules/@stdlib/math/base/special/asechf/lib/main.js b/lib/node_modules/@stdlib/math/base/special/asechf/lib/main.js
@@ -21,12 +21,12 @@
 // MODULES //
 
 var acoshf = require( '@stdlib/math/base/special/acoshf' );
-var f32 = require( '@stdlib/number/float64/base/to-float32' );
+var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
 
 
 // VARIABLES //
 
-var ONE = f32( 1.0 );
+var ONE = float64ToFloat32( 1.0 );
 
 
 // MAIN //
@@ -56,7 +56,7 @@ var ONE = f32( 1.0 );
 * // returns NaN
 */
 function asechf( x ) {
-	return acoshf( f32( ONE / f32( x ) ) );
+	return acoshf( float64ToFloat32( ONE / float64ToFloat32( x ) ) );
 }
 
 
diff --git a/lib/node_modules/@stdlib/math/base/special/asechf/test/fixtures/julia/runner.jl b/lib/node_modules/@stdlib/math/base/special/asechf/test/fixtures/julia/runner.jl
@@ -15,44 +15,53 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-#
 
 import JSON
 import Base: asech
 
 """
-gen( domain, name )
+    gen( domain, name )
 
 Generate fixture data and write to file.
 
 # Arguments
 
 * `domain`: domain
 * `name::AbstractString`: output filename
+
+# Examples
+
+``` julia
+julia> x = range( -1000, stop = 1000, length = 2022 );
+julia> gen( x, "data.json" );
+```
 """
 function gen( domain, name )
 	x = collect( domain );
+	y = Float32.( asech.( x ) );
 
-	y = Float32.( asech.( x ) )
-	data = Dict(
-		"x" => x,
-		"expected" => y
-	)
+	# Store data to be written to file as a collection:
+	data = Dict([
+		("x", x),
+		("expected", y)
+	]);
 
-	filepath = joinpath( dir, name )
+	# Based on the script directory, create an output filepath:
+	filepath = joinpath( dir, name );
 
-	open( filepath, "w" ) do io
-		write( io, JSON.json( data ) )
-		write( io, "\n" )
-	end
+	# Write the data to the output filepath as JSON:
+	outfile = open( filepath, "w" );
+	write( outfile, JSON.json(data) );
+	write( outfile, "\n" );
+	close( outfile );
 end
 
 # Get the filename:
-file = @__FILE__
+file = @__FILE__;
 
 # Extract the directory in which this file resides:
-dir = dirname( file )
+dir = dirname( file );
 
 # Generate values over the function domain:
-x = Float32.( range( 1.0e-5, stop = 1.0, length = 2003 ) )
-gen( x, "data.json" )
+x = Float32.( range( 1.0e-5, stop = 1.0, length = 2003 ) );
+gen( x, "data.json" );
diff --git a/lib/node_modules/@stdlib/math/base/special/asechf/test/test.js b/lib/node_modules/@stdlib/math/base/special/asechf/test/test.js
@@ -22,10 +22,11 @@
 
 var tape = require( 'tape' );
 var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
+var randu = require( '@stdlib/random/base/randu' );
 var abs = require( '@stdlib/math/base/special/abs' );
 var EPS = require( '@stdlib/constants/float32/eps' );
+var PINF = require( '@stdlib/constants/float64/pinf' );
 var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
-var max = require( '@stdlib/math/base/special/max' );
 var asechf = require( './../lib' );
 
 
@@ -56,46 +57,38 @@ tape( 'the function computes the hyperbolic arcsecant on the interval (0, 1]', f
 
 	for ( i = 0; i < x.length; i++ ) {
 		y = asechf( x[i] );
-		if ( y === expected[ i ] ) {
-			t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] );
+		e = float64ToFloat32( expected[i] );
+		if ( y === e ) {
+			t.strictEqual( y, e, 'x: '+x[i]+'. E: '+e );
 		} else {
-			e = float64ToFloat32( expected[i] );
 			delta = abs( y - e );
-			tol = max( 10.0 * EPS * abs( e ), 2.0e-6 );
-			t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
+			tol = 1.0 * EPS * abs( e );
+			t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' );
 		}
 	}
 	t.end();
 });
 
-tape( 'the function computes the hyperbolic arcsecant of 1', function test( t ) {
-	var v = asechf( 1.0 );
-	t.strictEqual( v, 0.0, 'returns expected value' );
-	t.end();
-});
-
-tape( 'the function computes the hyperbolic arcsecant of 0.5', function test( t ) {
-	var expected = float64ToFloat32( 1.3169578969248166 );
-	var delta;
-	var tol;
-	var v;
-
-	v = asechf( 0.5 );
-	delta = abs( v - expected );
-	tol = 10.0 * EPS;
-	t.ok( delta <= tol, 'within tolerance. v: ' + v + '. expected: ' + expected + '. Δ: ' + delta + '. tol: ' + tol + '.' );
+tape( 'the function returns `NaN` if provided `NaN`', function test( t ) {
+	var v = asechf( NaN );
+	t.strictEqual( isnanf( v ), true, 'returns expected value' );
 	t.end();
 });
 
-tape( 'the function returns `Infinity` for `x = 0`', function test( t ) {
+tape( 'the function returns `+infinity` if provided `+0`', function test( t ) {
 	var v = asechf( 0.0 );
-	t.strictEqual( v, Infinity, 'returns expected value' );
+	t.strictEqual( v, PINF, 'returns expected value' );
 	t.end();
 });
 
-tape( 'the function returns `NaN` for negative values', function test( t ) {
-	var v = asechf( -1.0 );
-	t.strictEqual( isnanf( v ), true, 'returns NaN' );
+tape( 'the function returns `NaN` if provided a value less than `0`', function test( t ) {
+	var v;
+	var i;
+
+	for ( i = 0; i < 1e3; i++ ) {
+		v = -(i+1) * randu();
+		t.strictEqual( isnanf( asechf( v ) ), true, 'returns NaN when provided '+v );
+	}
 	t.end();
 });
 
@@ -105,14 +98,14 @@ tape( 'the function returns `NaN` for negative zero', function test( t ) {
 	t.end();
 });
 
-tape( 'the function returns `NaN` for values greater than 1', function test( t ) {
-	var v = asechf( 2.0 );
-	t.strictEqual( isnanf( v ), true, 'returns NaN' );
-	t.end();
-});
+tape( 'the function returns `NaN` if provided a value greater than `1`', function test( t ) {
+	var v;
+	var i;
 
-tape( 'the function returns `NaN` if provided `NaN`', function test( t ) {
-	var v = asechf( NaN );
-	t.strictEqual( isnanf( v ), true, 'returns NaN' );
+	for ( i = 0; i < 1e3; i++ ) {
+		v = ( i * randu() * 100.0 ) + 1.0 + EPS;
+		t.strictEqual( isnanf( asechf( v ) ), true, 'returns NaN when provided '+v );
+	}
 	t.end();
 });
+
diff --git a/lib/node_modules/@stdlib/math/base/special/asechf/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/asechf/test/test.native.js
@@ -23,11 +23,12 @@
 var resolve = require( 'path' ).resolve;
 var tape = require( 'tape' );
 var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
-var abs = require( '@stdlib/math/base/special/abs' );
+var randu = require( '@stdlib/random/base/randu' );
 var EPS = require( '@stdlib/constants/float32/eps' );
+var PINF = require( '@stdlib/constants/float64/pinf' );
+var abs = require( '@stdlib/math/base/special/abs' );
 var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
 var tryRequire = require( '@stdlib/utils/try-require' );
-var max = require( '@stdlib/math/base/special/max' );
 
 
 // FIXTURES //
@@ -66,42 +67,37 @@ tape( 'the function computes the hyperbolic arcsecant on the interval (0, 1]', o
 	for ( i = 0; i < x.length; i++ ) {
 		y = asechf( x[i] );
 		e = float64ToFloat32( expected[i] );
-		delta = abs( y - e );
-		tol = max( 10.0 * EPS * abs( e ), 2.0e-6 );
-
-		t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' );
+		if ( y === e ) {
+			t.strictEqual( y, e, 'x: '+x[i]+'. E: '+e );
+		} else {
+			delta = abs( y - e );
+			tol = 1.0 * EPS * abs( e );
+			t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' );
+		}
 	}
 	t.end();
 });
 
-tape( 'the function computes the hyperbolic arcsecant of 1', opts, function test( t ) {
-	var v = asechf( 1.0 );
-	t.strictEqual( v, 0.0, 'returns expected value' );
-	t.end();
-});
-
-tape( 'the function computes the hyperbolic arcsecant of 0.5', opts, function test( t ) {
-	var expected = float64ToFloat32( 1.3169578969248166 );
-	var delta;
-	var tol;
-	var v;
-
-	v = asechf( 0.5 );
-	delta = abs( v - expected );
-	tol = 10.0 * EPS;
-	t.ok( delta <= tol, 'within tolerance. v: ' + v + '. expected: ' + expected + '. Δ: ' + delta + '. tol: ' + tol + '.' );
+tape( 'the function returns `NaN` if provided `NaN`', opts, function test( t ) {
+	var v = asechf( NaN );
+	t.strictEqual( isnanf( v ), true, 'returns expected value' );
 	t.end();
 });
 
-tape( 'the function returns `Infinity` for `x = 0`', opts, function test( t ) {
+tape( 'the function returns `+infinity` if provided `+0`', opts, function test( t ) {
 	var v = asechf( 0.0 );
-	t.strictEqual( v, Infinity, 'returns Infinity' );
+	t.strictEqual( v, PINF, 'returns expected value' );
 	t.end();
 });
 
-tape( 'the function returns `NaN` for negative values', opts, function test( t ) {
-	var v = asechf( -1.0 );
-	t.strictEqual( isnanf( v ), true, 'returns NaN' );
+tape( 'the function returns `NaN` if provided a value less than `0`', opts, function test( t ) {
+	var v;
+	var i;
+
+	for ( i = 0; i < 1e3; i++ ) {
+		v = -(i+1) * randu();
+		t.strictEqual( isnanf( asechf( v ) ), true, 'returns NaN when provided '+v );
+	}
 	t.end();
 });
 
@@ -111,14 +107,13 @@ tape( 'the function returns `NaN` for negative zero', opts, function test( t ) {
 	t.end();
 });
 
-tape( 'the function returns `NaN` for values greater than 1', opts, function test( t ) {
-	var v = asechf( 2.0 );
-	t.strictEqual( isnanf( v ), true, 'returns NaN' );
-	t.end();
-});
+tape( 'the function returns `NaN` if provided a value greater than `1`', opts, function test( t ) {
+	var v;
+	var i;
 
-tape( 'the function returns `NaN` if provided `NaN`', opts, function test( t ) {
-	var v = asechf( NaN );
-	t.strictEqual( isnanf( v ), true, 'returns NaN' );
+	for ( i = 0; i < 1e3; i++ ) {
+		v = ( i * randu() * 100.0 ) + 1.0 + EPS;
+		t.strictEqual( isnanf( asechf( v ) ), true, 'returns NaN when provided '+v );
+	}
 	t.end();
 });
