Skip to content

Commit 0eef914

Browse files
committed
fix: apply suggestions from code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 73042f5 commit 0eef914

2 files changed

Lines changed: 18 additions & 46 deletions

File tree

lib/node_modules/@stdlib/blas/ext/base/zdiff/lib/base.js

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -144,30 +144,16 @@ function base( N, x, strideX, offsetX, N1, prepend, strideP, offsetP, N2, append
144144
}
145145
// Compute forward differences over the input array:
146146
if ( N > 0 ) {
147-
if ( N1 === 0 ) {
148-
ix += sx;
149-
for ( i = 1; i < N; i++ ) {
150-
rcurr = xv[ ix ];
151-
icurr = xv[ ix+1 ];
152-
ov[ io ] = rcurr - rprev;
153-
ov[ io+1 ] = icurr - iprev;
154-
rprev = rcurr;
155-
iprev = icurr;
156-
io += so;
157-
ix += sx;
158-
}
159-
} else {
147+
ix += sx;
148+
for ( i = 1; i < N; i++ ) {
149+
rcurr = xv[ ix ];
150+
icurr = xv[ ix+1 ];
151+
ov[ io ] = rcurr - rprev;
152+
ov[ io+1 ] = icurr - iprev;
153+
rprev = rcurr;
154+
iprev = icurr;
155+
io += so;
160156
ix += sx;
161-
for ( i = 1; i < N; i++ ) {
162-
rcurr = xv[ ix ];
163-
icurr = xv[ ix+1 ];
164-
ov[ io ] = rcurr - rprev;
165-
ov[ io+1 ] = icurr - iprev;
166-
rprev = rcurr;
167-
iprev = icurr;
168-
io += so;
169-
ix += sx;
170-
}
171157
}
172158
if ( N2 > 0 ) {
173159
rcurr = av[ ia ];

lib/node_modules/@stdlib/blas/ext/base/zdiff/src/main.c

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -130,30 +130,16 @@ static void stdlib_strided_internal_zdiff_ndarray( const CBLAS_INT N, const void
130130
}
131131
// Calculate the forward difference over the input array...
132132
if ( N > 0 ) {
133-
if ( N1 == 0 ) {
134-
ix += sx;
135-
for ( i = 1; i < N; i++ ) {
136-
rcurr = xv[ ix ];
137-
icurr = xv[ ix+1 ];
138-
ov[ io ] = rcurr - rprev;
139-
ov[ io+1 ] = icurr - iprev;
140-
rprev = rcurr;
141-
iprev = icurr;
142-
io += so;
143-
ix += sx;
144-
}
145-
} else {
133+
ix += sx;
134+
for ( i = 1; i < N; i++ ) {
135+
rcurr = xv[ ix ];
136+
icurr = xv[ ix+1 ];
137+
ov[ io ] = rcurr - rprev;
138+
ov[ io+1 ] = icurr - iprev;
139+
rprev = rcurr;
140+
iprev = icurr;
141+
io += so;
146142
ix += sx;
147-
for ( i = 1; i < N; i++ ) {
148-
rcurr = xv[ ix ];
149-
icurr = xv[ ix+1 ];
150-
ov[ io ] = rcurr - rprev;
151-
ov[ io+1 ] = icurr - iprev;
152-
rprev = rcurr;
153-
iprev = icurr;
154-
io += so;
155-
ix += sx;
156-
}
157143
}
158144
if ( N2 > 0 ) {
159145
rcurr = av[ ia ];

0 commit comments

Comments
 (0)