Skip to content

Commit 15e9d74

Browse files
authored
bench: refactor to use string interpolation and array literals in stats/padjust
PR-URL: #10208 Ref: #8647 Reviewed-by: Athan Reines <kgryte@gmail.com>
1 parent 570b077 commit 15e9d74

File tree

1 file changed

+21
-30
lines changed
  • lib/node_modules/@stdlib/stats/padjust/benchmark

1 file changed

+21
-30
lines changed

lib/node_modules/@stdlib/stats/padjust/benchmark/benchmark.js

Lines changed: 21 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -23,22 +23,21 @@
2323
var bench = require( '@stdlib/bench' );
2424
var randu = require( '@stdlib/random/base/randu' );
2525
var isProbabilityArray = require( '@stdlib/assert/is-probability-array' );
26+
var format = require( '@stdlib/string/format' );
2627
var pkg = require( './../package.json' ).name;
2728
var padjust = require( './../lib' );
2829

2930

3031
// MAIN //
3132

32-
bench( pkg+':method=bonferroni', function benchmark( b ) {
33+
bench( format( '%s:method=bonferroni', pkg ), function benchmark( b ) {
3334
var result;
3435
var pvals;
35-
var len;
3636
var i;
3737

38-
pvals = new Array( 10 );
39-
len = pvals.length;
40-
for ( i = 0; i < len; i++ ) {
41-
pvals[ i ] = randu() * 0.5;
38+
pvals = [];
39+
for ( i = 0; i < 10; i++ ) {
40+
pvals.push( randu() * 0.5 );
4241
}
4342
b.tic();
4443
for ( i = 0; i < b.iterations; i++ ) {
@@ -56,16 +55,14 @@ bench( pkg+':method=bonferroni', function benchmark( b ) {
5655
b.end();
5756
});
5857

59-
bench( pkg+':method=bh', function benchmark( b ) {
58+
bench( format( '%s:method=bh', pkg ), function benchmark( b ) {
6059
var result;
6160
var pvals;
62-
var len;
6361
var i;
6462

65-
pvals = new Array( 10 );
66-
len = pvals.length;
67-
for ( i = 0; i < len; i++ ) {
68-
pvals[ i ] = randu() * 0.5;
63+
pvals = [];
64+
for ( i = 0; i < 10; i++ ) {
65+
pvals.push( randu() * 0.5 );
6966
}
7067
b.tic();
7168
for ( i = 0; i < b.iterations; i++ ) {
@@ -83,16 +80,14 @@ bench( pkg+':method=bh', function benchmark( b ) {
8380
b.end();
8481
});
8582

86-
bench( pkg+':method=by', function benchmark( b ) {
83+
bench( format( '%s:method=by', pkg ), function benchmark( b ) {
8784
var result;
8885
var pvals;
89-
var len;
9086
var i;
9187

92-
pvals = new Array( 10 );
93-
len = pvals.length;
94-
for ( i = 0; i < len; i++ ) {
95-
pvals[ i ] = randu() * 0.5;
88+
pvals = [];
89+
for ( i = 0; i < 10; i++ ) {
90+
pvals.push( randu() * 0.5 );
9691
}
9792
b.tic();
9893
for ( i = 0; i < b.iterations; i++ ) {
@@ -110,16 +105,14 @@ bench( pkg+':method=by', function benchmark( b ) {
110105
b.end();
111106
});
112107

113-
bench( pkg+':method=holm', function benchmark( b ) {
108+
bench( format( '%s:method=holm', pkg ), function benchmark( b ) {
114109
var result;
115110
var pvals;
116-
var len;
117111
var i;
118112

119-
pvals = new Array( 10 );
120-
len = pvals.length;
121-
for ( i = 0; i < len; i++ ) {
122-
pvals[ i ] = randu() * 0.5;
113+
pvals = [];
114+
for ( i = 0; i < 10; i++ ) {
115+
pvals.push( randu() * 0.5 );
123116
}
124117
b.tic();
125118
for ( i = 0; i < b.iterations; i++ ) {
@@ -137,16 +130,14 @@ bench( pkg+':method=holm', function benchmark( b ) {
137130
b.end();
138131
});
139132

140-
bench( pkg+':method=hommel', function benchmark( b ) {
133+
bench( format( '%s:method=hommel', pkg ), function benchmark( b ) {
141134
var result;
142135
var pvals;
143-
var len;
144136
var i;
145137

146-
pvals = new Array( 10 );
147-
len = pvals.length;
148-
for ( i = 0; i < len; i++ ) {
149-
pvals[ i ] = randu() * 0.5;
138+
pvals = [];
139+
for ( i = 0; i < 10; i++ ) {
140+
pvals.push( randu() * 0.5 );
150141
}
151142
b.tic();
152143
for ( i = 0; i < b.iterations; i++ ) {

0 commit comments

Comments
 (0)