Skip to content

Commit 178a483

Browse files
committed
fix: apply suggestions from code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent d91c1d8 commit 178a483

2 files changed

Lines changed: 6 additions & 18 deletions

File tree

lib/node_modules/@stdlib/blas/ext/base/gdiff/benchmark/benchmark.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
var bench = require( '@stdlib/bench' );
2424
var uniform = require( '@stdlib/random/array/uniform' );
25+
var zeros = require( '@stdlib/array/zeros' );
2526
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2627
var pow = require( '@stdlib/math/base/special/pow' );
2728
var format = require( '@stdlib/string/format' );
@@ -56,7 +57,6 @@ function createBenchmark( len ) {
5657
var o;
5758
var k;
5859
var N;
59-
var i;
6060

6161
N = len;
6262
N1 = 1;
@@ -67,14 +67,8 @@ function createBenchmark( len ) {
6767
x = uniform( N, -100, 100, options );
6868
p = uniform( N1, -100, 100, options );
6969
a = uniform( N2, -100, 100, options );
70-
w = [];
71-
for ( i = 0; i < N+N1+N2-1; i++ ) {
72-
w.push( 0.0 );
73-
}
74-
o = [];
75-
for ( i = 0; i < ol; i++ ) {
76-
o.push( 0.0 );
77-
}
70+
w = zeros( N+N1+N2-1, 'generic' );
71+
o = zeros( ol, 'generic' );
7872
return benchmark;
7973

8074
/**

lib/node_modules/@stdlib/blas/ext/base/gdiff/benchmark/benchmark.ndarray.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
var bench = require( '@stdlib/bench' );
2424
var uniform = require( '@stdlib/random/array/uniform' );
25+
var zeros = require( '@stdlib/array/zeros' );
2526
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2627
var pow = require( '@stdlib/math/base/special/pow' );
2728
var format = require( '@stdlib/string/format' );
@@ -56,7 +57,6 @@ function createBenchmark( len ) {
5657
var o;
5758
var k;
5859
var N;
59-
var i;
6060

6161
N = len;
6262
N1 = 1;
@@ -67,14 +67,8 @@ function createBenchmark( len ) {
6767
x = uniform( N, -100, 100, options );
6868
p = uniform( N1, -100, 100, options );
6969
a = uniform( N2, -100, 100, options );
70-
w = [];
71-
for ( i = 0; i < N+N1+N2-1; i++ ) {
72-
w.push( 0.0 );
73-
}
74-
o = [];
75-
for ( i = 0; i < ol; i++ ) {
76-
o.push( 0.0 );
77-
}
70+
w = zeros( N+N1+N2-1, 'generic' );
71+
o = zeros( ol, 'generic' );
7872
return benchmark;
7973

8074
/**

0 commit comments

Comments
 (0)