fix: apply suggestions from code review

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: headlessNode

lib/node_modules/@stdlib/blas/ext/base/gvander/docs/repl.txt

@@ -5,8 +5,8 @@
     When the mode is positive, the matrix is generated such that
 
         [
-            1   x_0^1   x_0^2   ...   x_0^N
-            1   x_1^1   x_1^2   ...   x_1^N
+            1   x_0^1   x_0^2   ...   x_0^(N-1)
+            1   x_1^1   x_1^2   ...   x_1^(N-1)
             ...
         ]
 
@@ -15,8 +15,8 @@
     When the mode is negative, the matrix is generated such that
 
         [
-            x_0^N   ...   x_0^2   x_0^1   1
-            x_1^N   ...   x_1^2   x_1^1   1
+            x_0^(N-1)   ...   x_0^2   x_0^1   1
+            x_1^(N-1)   ...   x_1^2   x_1^1   1
             ...
         ]
 

lib/node_modules/@stdlib/blas/ext/base/gvander/lib/accessors.js

@@ -107,10 +107,10 @@ function gvander( mode, M, N, x, sx, ox, out, so1, so2, oo ) {
 		S0 = N;
 		S1 = M;
 		do0 = so2;
-		do1 = so1 + ( S0*so2 );
-		io = oo + ( ( S0-1 ) * do0 );
-		ix = ox;
-		for ( i1 = 0; i1 < S1; i1++ ) {
+		do1 = so1 - ( S0*so2 );
+		io = oo + ( ( S1-1 ) * so1 ) + ( ( S0-1 ) * so2 );
+		ix = ox + ( ( S1-1 ) * sx );
+		for ( i1 = S1-1; i1 >= 0; i1-- ) {
 			v = xget( xbuf, ix );
 			oset( obuf, io, 1.0 );
 			tmp = 1.0;
@@ -120,8 +120,8 @@ function gvander( mode, M, N, x, sx, ox, out, so1, so2, oo ) {
 				oset( obuf, io, tmp );
 				io -= do0;
 			}
-			ix += sx;
-			io += do1;
+			ix -= sx;
+			io -= do1;
 		}
 	} else if ( mode > 0 ) {
 		// Column-major, increasing: column j contains x^j
@@ -145,15 +145,18 @@ function gvander( mode, M, N, x, sx, ox, out, so1, so2, oo ) {
 		// Column-major, decreasing: column 0 contains x^(N-1), last column all ones
 		S0 = M;
 		S1 = N;
+		do0 = so1;
+		do1 = so2 - ( S0*so1 );
 		gfill( S0, 1.0, obuf, so1, oo + ( ( S1-1 ) * so2 ) );
-		for ( i1 = S1 - 2; i1 >= 0; i1-- ) {
-			io = oo + ( i1 * so2 );
-			ix = ox;
-			for ( i0 = 0; i0 < S0; i0++ ) {
+		io = oo + ( ( S1-2 ) * so2 ) + ( ( S0-1 ) * so1 );
+		for ( i1 = S1-2; i1 >= 0; i1-- ) {
+			ix = ox + ( ( S0-1 ) * sx );
+			for ( i0 = S0-1; i0 >= 0; i0-- ) {
 				oset( obuf, io, oget( obuf, io + so2 ) * xget( xbuf, ix ) );
-				ix += sx;
-				io += so1;
+				ix -= sx;
+				io -= do0;
 			}
+			io -= do1;
 		}
 	}
 	return obuf;

lib/node_modules/@stdlib/blas/ext/base/gvander/lib/base.js

@@ -81,12 +81,12 @@ function gvander( mode, M, N, x, strideX, offsetX, out, strideOut1, strideOut2,
 		S0 = N;
 		S1 = M;
 		do0 = strideOut2;
-		ix = offsetX;
 
 		// Increasing: x^0, x^1, ..., x^(N-1)
 		if ( mode > 0 ) {
 			do1 = strideOut1 - ( S0*strideOut2 );
 			io = offsetOut;
+			ix = offsetX;
 			for ( i1 = 0; i1 < S1; i1++ ) {
 				out[ io ] = 1.0;
 				io += do0;
@@ -100,24 +100,25 @@ function gvander( mode, M, N, x, strideX, offsetX, out, strideOut1, strideOut2,
 			return out;
 		}
 		// Decreasing: x^(N-1), x^(N-2), ..., x^0
-		do1 = strideOut1 + ( S0*strideOut2 );
-		io = offsetOut + ( ( S0-1 ) * strideOut2 );
-		for ( i1 = 0; i1 < S1; i1++ ) {
+		do1 = strideOut1 - ( S0*strideOut2 );
+		io = offsetOut + ( ( S1-1 ) * strideOut1 ) + ( ( S0-1 ) * strideOut2 );
+		ix = offsetX + ( ( S1-1 ) * sx );
+		for ( i1 = S1-1; i1 >= 0; i1-- ) {
 			out[ io ] = 1.0;
 			io -= do0;
 			for ( i0 = 1; i0 < S0; i0++ ) {
 				out[ io ] = out[ io+do0 ] * x[ ix ];
 				io -= do0;
 			}
-			ix += sx;
-			io += do1;
+			ix -= sx;
+			io -= do1;
 		}
 		return out;
 	}
 	// Column-major...
 	S0 = M;
 	S1 = N;
-	
+
 	// Increasing: column j contains x^j
 	if ( mode > 0 ) {
 		gfill( S0, 1.0, out, strideOut1, offsetOut );
@@ -137,14 +138,17 @@ function gvander( mode, M, N, x, strideX, offsetX, out, strideOut1, strideOut2,
 	}
 	// Decreasing: column 0 contains x^(N-1), last column all ones
 	gfill( S0, 1.0, out, strideOut1, offsetOut + ( ( S1-1 ) * strideOut2 ) );
+	do0 = strideOut1;
+	do1 = strideOut2 - ( S0*strideOut1 );
+	io = offsetOut + ( ( S1-2 ) * strideOut2 ) + ( ( S0-1 ) * strideOut1 );
 	for ( i1 = S1-2; i1 >= 0; i1-- ) {
-		io = offsetOut + ( i1*strideOut2 );
-		ix = offsetX;
-		for ( i0 = 0; i0 < S0; i0++ ) {
+		ix = offsetX + ( ( S0-1 ) * sx );
+		for ( i0 = S0-1; i0 >= 0; i0-- ) {
 			out[ io ] = out[ io+strideOut2 ] * x[ ix ];
-			ix += sx;
-			io += strideOut1;
+			ix -= sx;
+			io -= do0;
 		}
+		io -= do1;
 	}
 	return out;
 }