Skip to content

Commit 3bd0331

Browse files
kgrytekgryte
committed
test: fix assertions and descriptions
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent fe150a0 commit 3bd0331

2 files changed

Lines changed: 18 additions & 19 deletions

File tree

‎lib/node_modules/@stdlib/blas/ext/to-sortedhp/test/test.assign.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -625,7 +625,7 @@ tape( 'the function throws an error if provided a second argument which does not
625625
}
626626
});
627627

628-
tape( 'the function throws an error if provided a second argument having dimensions greater than or less than the dimensions of input ndarray', function test( t ) {
628+
tape( 'the function throws an error if provided a second argument having a shape which is incompatible with the input ndarray', function test( t ) {
629629
var values;
630630
var i;
631631

@@ -649,7 +649,7 @@ tape( 'the function throws an error if provided a second argument having dimensi
649649
}
650650
});
651651

652-
tape( 'the function throws an error if provided a `sortOrder` argument which is not an ndarray-like object, a numeric scalar, or a support string', function test( t ) {
652+
tape( 'the function throws an error if provided a `sortOrder` argument which is not an ndarray-like object, a numeric scalar, or a supported string', function test( t ) {
653653
var values;
654654
var x;
655655
var y;
@@ -684,7 +684,7 @@ tape( 'the function throws an error if provided a `sortOrder` argument which is
684684
}
685685
});
686686

687-
tape( 'the function throws an error if provided a `sortOrder` argument which is not an ndarray-like object, a numeric scalar, or a support string (options)', function test( t ) {
687+
tape( 'the function throws an error if provided a `sortOrder` argument which is not an ndarray-like object, a numeric scalar, or a supported string (options)', function test( t ) {
688688
var values;
689689
var x;
690690
var y;

‎lib/node_modules/@stdlib/blas/ext/to-sortedhp/test/test.main.js‎

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ var isSameArray = require( '@stdlib/assert/is-same-array' );
2626
var Float64Array = require( '@stdlib/array/float64' );
2727
var Float32Array = require( '@stdlib/array/float32' );
2828
var Int8Array = require( '@stdlib/array/int8' );
29-
var resolveStr = require( '@stdlib/ndarray/base/dtype-resolve-str' );
3029
var ndarray = require( '@stdlib/ndarray/ctor' );
3130
var zeros = require( '@stdlib/ndarray/zeros' );
3231
var empty = require( '@stdlib/ndarray/empty' );
@@ -1365,7 +1364,7 @@ tape( 'the function supports providing a `sortOrder` argument (0d ndarray)', fun
13651364
expected = [-3.0, -1.0, 2.0, 4.0 ];
13661365

13671366
t.notEqual( actual, x, 'returns expected value' );
1368-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1367+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
13691368
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
13701369
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
13711370
t.strictEqual( isSameArray( getData( actual ), expected ), true, 'returns expected value' );
@@ -1377,7 +1376,7 @@ tape( 'the function supports providing a `sortOrder` argument (0d ndarray)', fun
13771376
expected = [ 4.0, 2.0, -1.0, -3.0 ];
13781377

13791378
t.notEqual( actual, x, 'returns expected value' );
1380-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1379+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
13811380
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
13821381
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
13831382
t.strictEqual( isSameArray( getData( actual ), expected ), true, 'returns expected value' );
@@ -1389,7 +1388,7 @@ tape( 'the function supports providing a `sortOrder` argument (0d ndarray)', fun
13891388
expected = [ -1.0, 2.0, -3.0, 4.0 ];
13901389

13911390
t.notEqual( actual, x, 'returns expected value' );
1392-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1391+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
13931392
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
13941393
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
13951394
t.strictEqual( isSameArray( getData( actual ), expected ), true, 'returns expected value' );
@@ -1414,7 +1413,7 @@ tape( 'the function supports providing a `sortOrder` argument (0d ndarray, optio
14141413
expected = [ -3.0, -1.0, 2.0, 4.0 ];
14151414

14161415
t.notEqual( actual, x, 'returns expected value' );
1417-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1416+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
14181417
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
14191418
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
14201419
t.strictEqual( isSameArray( getData( actual ), expected ), true, 'returns expected value' );
@@ -1426,7 +1425,7 @@ tape( 'the function supports providing a `sortOrder` argument (0d ndarray, optio
14261425
expected = [ 4.0, 2.0, -1.0, -3.0 ];
14271426

14281427
t.notEqual( actual, x, 'returns expected value' );
1429-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1428+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
14301429
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
14311430
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
14321431
t.strictEqual( isSameArray( getData( actual ), expected ), true, 'returns expected value' );
@@ -1438,7 +1437,7 @@ tape( 'the function supports providing a `sortOrder` argument (0d ndarray, optio
14381437
expected = [ -1.0, 2.0, -3.0, 4.0 ];
14391438

14401439
t.notEqual( actual, x, 'returns expected value' );
1441-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1440+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
14421441
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
14431442
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
14441443
t.strictEqual( isSameArray( getData( actual ), expected ), true, 'returns expected value' );
@@ -1516,7 +1515,7 @@ tape( 'the function supports providing a `sortOrder` argument (0d ndarray, broad
15161515
expected = [ [ -3.0, 2.0 ], [ -1.0, 4.0 ] ];
15171516

15181517
t.notEqual( actual, x, 'returns expected value' );
1519-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1518+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
15201519
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
15211520
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
15221521
t.deepEqual( ndarray2array( actual ), expected, 'returns expected value' );
@@ -1530,7 +1529,7 @@ tape( 'the function supports providing a `sortOrder` argument (0d ndarray, broad
15301529
expected = [ [ 2.0, 4.0 ], [ -1.0, -3.0 ] ];
15311530

15321531
t.notEqual( actual, x, 'returns expected value' );
1533-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1532+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
15341533
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
15351534
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
15361535
t.deepEqual( ndarray2array( actual ), expected, 'returns expected value' );
@@ -1544,7 +1543,7 @@ tape( 'the function supports providing a `sortOrder` argument (0d ndarray, broad
15441543
expected = [ [ -1.0, -3.0 ], [ 2.0, 4.0 ] ];
15451544

15461545
t.notEqual( actual, x, 'returns expected value' );
1547-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1546+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
15481547
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
15491548
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
15501549
t.deepEqual( ndarray2array( actual ), expected, 'returns expected value' );
@@ -1667,7 +1666,7 @@ tape( 'the function supports providing a `sortOrder` argument (ndarray)', functi
16671666
expected = [ [ -3.0, 4.0 ], [ -1.0, 2.0 ] ];
16681667

16691668
t.notEqual( actual, x, 'returns expected value' );
1670-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1669+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
16711670
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
16721671
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
16731672
t.deepEqual( ndarray2array( actual ), expected, 'returns expected value' );
@@ -1683,7 +1682,7 @@ tape( 'the function supports providing a `sortOrder` argument (ndarray)', functi
16831682
expected = [ [ -1.0, 4.0 ], [ 2.0, -3.0 ] ];
16841683

16851684
t.notEqual( actual, x, 'returns expected value' );
1686-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1685+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
16871686
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
16881687
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
16891688
t.deepEqual( ndarray2array( actual ), expected, 'returns expected value' );
@@ -1699,7 +1698,7 @@ tape( 'the function supports providing a `sortOrder` argument (ndarray)', functi
16991698
expected = [ [ 1.0, -2.0 ], [ 4.0, -3.0 ] ];
17001699

17011700
t.notEqual( actual, x, 'returns expected value' );
1702-
t.strictEqual( getDType( actual ), opts.dtype, 'returns expected value' );
1701+
t.strictEqual( isEqualDataType( getDType( actual ), getDType( x ) ), true, 'returns expected value' );
17031702
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
17041703
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
17051704
t.deepEqual( ndarray2array( actual ), expected, 'returns expected value' );
@@ -1722,7 +1721,7 @@ tape( 'the function supports specifying an output data type', function test( t )
17221721
expected = [ [ -3.0, -1.0 ], [ 2.0, 4.0 ] ];
17231722

17241723
t.notEqual( actual, x, 'returns expected value' );
1725-
t.strictEqual( resolveStr( getDType( actual ) ), 'float64', 'returns expected value' );
1724+
t.strictEqual( isEqualDataType( getDType( actual ), 'float64' ), true, 'returns expected value' );
17261725
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
17271726
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
17281727
t.deepEqual( ndarray2array( actual ), expected, 'returns expected value' );
@@ -1745,7 +1744,7 @@ tape( 'the function supports specifying an output data type (sortOrder=scalar)',
17451744
expected = [ [ -3.0, -1.0 ], [ 2.0, 4.0 ] ];
17461745

17471746
t.notEqual( actual, x, 'returns expected value' );
1748-
t.strictEqual( resolveStr( getDType( actual ) ), 'float32', 'returns expected value' );
1747+
t.strictEqual( isEqualDataType( getDType( actual ), 'float32' ), true, 'returns expected value' );
17491748
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
17501749
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
17511750
t.deepEqual( ndarray2array( actual ), expected, 'returns expected value' );
@@ -1768,7 +1767,7 @@ tape( 'the function supports specifying an output data type (sortOrder=string)',
17681767
expected = [ [ 4, 2 ], [ -1, -3 ] ];
17691768

17701769
t.notEqual( actual, x, 'returns expected value' );
1771-
t.strictEqual( resolveStr( getDType( actual ) ), 'int32', 'returns expected value' );
1770+
t.strictEqual( isEqualDataType( getDType( actual ), 'int32' ), true, 'returns expected value' );
17721771
t.deepEqual( getShape( actual ), getShape( x ), 'returns expected value' );
17731772
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
17741773
t.deepEqual( ndarray2array( actual ), expected, 'returns expected value' );

0 commit comments

Comments
 (0)