refactor: perform explicit push when using generic arrays

PR-URL: #9873
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>

Author: Om-A-osc

lib/node_modules/@stdlib/stats/ranks/benchmark/benchmark.js

@@ -21,7 +21,7 @@
 // MODULES //
 
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var uniform = require( '@stdlib/random/array/uniform' );
 var isArray = require( '@stdlib/assert/is-array' );
 var pkg = require( './../package.json' ).name;
 var ranks = require( './../lib' );
@@ -32,18 +32,15 @@ var ranks = require( './../lib' );
 bench( pkg, function benchmark( b ) {
 	var result;
 	var arr;
-	var len;
 	var i;
 
-	arr = new Array( 100 );
-	len = arr.length;
-	for ( i = 0; i < len; i++ ) {
-		arr[ i ] = ( randu()*100.0 ) - 50.0;
-	}
+	arr = uniform( 100, -50.0, 50.0, {
+		'dtype': 'generic'
+	});
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		arr[ 0 ] = ( randu()*100.0 ) - 50.0;
+		arr[ 0 ] = i;
 		result = ranks( arr );
 		if ( typeof result !== 'object' ) {
 			b.fail( 'should return an object' );

lib/node_modules/@stdlib/stats/ranks/lib/order.js

@@ -52,9 +52,9 @@ function order( x ) {
 	var arr;
 	var i;
 
-	arr = new Array( x.length );
+	arr = [];
 	for ( i = 0; i < x.length; i++ ) {
-		arr[ i ] = i;
+		arr.push( i );
 	}
 	return arr.sort( compare );