refactor: reuse variance in stats/base/dists/bernoulli/stdev

PR-URL: #11366
Reviewed-by: Athan Reines <kgryte@gmail.com>

Author: Om-A-osc

lib/node_modules/@stdlib/stats/base/dists/bernoulli/stdev/lib/main.js

@@ -20,8 +20,8 @@
 
 // MODULES //
 
-var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var sqrt = require( '@stdlib/math/base/special/sqrt' );
+var variance = require( '@stdlib/stats/base/dists/bernoulli/variance' );
 
 
 // MAIN //
@@ -49,14 +49,7 @@ var sqrt = require( '@stdlib/math/base/special/sqrt' );
 * // returns NaN
 */
 function stdev( p ) {
-	if (
-		isnan( p ) ||
-		p < 0.0 ||
-		p > 1.0
-	) {
-		return NaN;
-	}
-	return sqrt( ( 1.0-p ) * p );
+	return sqrt( variance( p ) );
 }
 
 

lib/node_modules/@stdlib/stats/base/dists/bernoulli/stdev/manifest.json

@@ -39,8 +39,8 @@
       "libpath": [],
       "dependencies": [
         "@stdlib/math/base/napi/unary",
-        "@stdlib/math/base/assert/is-nan",
-        "@stdlib/math/base/special/sqrt"
+        "@stdlib/math/base/special/sqrt",
+        "@stdlib/stats/base/dists/bernoulli/variance"
       ]
     },
     {
@@ -55,8 +55,8 @@
       "libraries": [],
       "libpath": [],
       "dependencies": [
-        "@stdlib/math/base/assert/is-nan",
-        "@stdlib/math/base/special/sqrt"
+        "@stdlib/math/base/special/sqrt",
+        "@stdlib/stats/base/dists/bernoulli/variance"
       ]
     },
     {
@@ -71,8 +71,8 @@
       "libraries": [],
       "libpath": [],
       "dependencies": [
-        "@stdlib/math/base/assert/is-nan",
-        "@stdlib/math/base/special/sqrt"
+        "@stdlib/math/base/special/sqrt",
+        "@stdlib/stats/base/dists/bernoulli/variance"
       ]
     }
   ]

lib/node_modules/@stdlib/stats/base/dists/bernoulli/stdev/src/main.c

@@ -17,8 +17,8 @@
 */
 
 #include "stdlib/stats/base/dists/bernoulli/stdev.h"
-#include "stdlib/math/base/assert/is_nan.h"
 #include "stdlib/math/base/special/sqrt.h"
+#include "stdlib/stats/base/dists/bernoulli/variance.h"
 
 /**
 * Returns the standard deviation of a Bernoulli distribution.
@@ -31,12 +31,5 @@
 * // returns ~0.3
 */
 double stdlib_base_dists_bernoulli_stdev( const double p ) {
-	if (
-		stdlib_base_is_nan( p ) ||
-		p < 0.0 ||
-		p > 1.0
-	) {
-		return 0.0/0.0; // NaN
-	}
-	return stdlib_base_sqrt( ( 1.0-p ) * p );
+	return stdlib_base_sqrt( stdlib_base_dists_bernoulli_variance( p ) );
 }