Skip to content

Commit 4bd7c0e

Browse files
authored
Apply suggestions from code review
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
1 parent 90d98ba commit 4bd7c0e

2 files changed

Lines changed: 0 additions & 80 deletions

File tree

lib/node_modules/@stdlib/blas/ext/base/gvander/test/test.main.js

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -173,46 +173,6 @@ tape( 'the function throws an error if provided an invalid fourth argument (acce
173173
}
174174
});
175175

176-
tape( 'the function throws an error if provided an invalid sixth argument', function test( t ) {
177-
var values;
178-
var i;
179-
180-
values = [
181-
0
182-
];
183-
184-
for ( i = 0; i < values.length; i++ ) {
185-
t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
186-
}
187-
t.end();
188-
189-
function badValue( value ) {
190-
return function badValue() {
191-
gvander( 'row-major', -1, 3, 3, [ 1.0, 2.0, 3.0 ], value, [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ], 3 );
192-
};
193-
}
194-
});
195-
196-
tape( 'the function throws an error if provided an invalid sixth argument (accessors)', function test( t ) {
197-
var values;
198-
var i;
199-
200-
values = [
201-
0
202-
];
203-
204-
for ( i = 0; i < values.length; i++ ) {
205-
t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
206-
}
207-
t.end();
208-
209-
function badValue( value ) {
210-
return function badValue() {
211-
gvander( 'row-major', -1, 3, 3, toAccessorArray( [ 1.0, 2.0, 3.0 ] ), value, toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ] ), 3 );
212-
};
213-
}
214-
});
215-
216176
tape( 'the function throws an error if provided an invalid eighth argument', function test( t ) {
217177
var values;
218178
var i;

lib/node_modules/@stdlib/blas/ext/base/gvander/test/test.ndarray.js

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -126,46 +126,6 @@ tape( 'the function throws an error if provided an invalid third argument (acces
126126
}
127127
});
128128

129-
tape( 'the function throws an error if provided an invalid fifth argument', function test( t ) {
130-
var values;
131-
var i;
132-
133-
values = [
134-
0
135-
];
136-
137-
for ( i = 0; i < values.length; i++ ) {
138-
t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
139-
}
140-
t.end();
141-
142-
function badValue( value ) {
143-
return function badValue() {
144-
gvander( -1, 3, 3, [ 1.0, 2.0, 3.0 ], value, 0, [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ], 3, 1, 0 ); // eslint-disable-line max-len
145-
};
146-
}
147-
});
148-
149-
tape( 'the function throws an error if provided an invalid fifth argument (accessors)', function test( t ) {
150-
var values;
151-
var i;
152-
153-
values = [
154-
0
155-
];
156-
157-
for ( i = 0; i < values.length; i++ ) {
158-
t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
159-
}
160-
t.end();
161-
162-
function badValue( value ) {
163-
return function badValue() {
164-
gvander( -1, 3, 3, toAccessorArray( [ 1.0, 2.0, 3.0 ] ), value, 0, toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ] ), 3, 1, 0 ); // eslint-disable-line max-len
165-
};
166-
}
167-
});
168-
169129
tape( 'the function generates a Vandermonde matrix (row-major, decreasing)', function test( t ) {
170130
var expected;
171131
var out;

0 commit comments

Comments
 (0)